Feature/test scripts signup #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/test-scripts-signup
themodernpk
requested changes
Nov 17, 2022
README.md
Outdated
|
|
||
| ## Objectives | ||
| - Reduce code for `selecting` elements and verifying `asserts` | ||
| - Code `re-usability` by writing the test scripts independent of the `data` and `POM`. |
There was a problem hiding this comment.
@satyajeet-s001 write the full form of POM in brackets
There was a problem hiding this comment.
Updated sir!
README.md
Outdated
|
|
||
| #### step 5: All the methods present in Assert class under Assets in vaah-webdriverio should be prefixed with "async" to run the methods in async mode in the test scripts. | ||
| #### step 5: All the values which are required for the `signup.page.js` and `signup.spec.js` should be present in `signup.js` under `data` and for the values which are required for the test scripts, it should be arranged in `groups` and `tests` in JSON format. |
There was a problem hiding this comment.
@satyajeet-s001 instead of signup.js under data write proper path like <root>/data/signin.js, fix this everywhere else as well.
There was a problem hiding this comment.
Updated !
| } | ||
|
|
||
| this.selectors = { | ||
| first_name: 'First Name', |
There was a problem hiding this comment.
@satyajeet-s001 how selector will be a First Name, it will be a data-testid attribute, explain that this is a data-testid attribute value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the common list of Sign In test scripts in which i have created separate file for pom and data to make the code reusable.
refer:
video_URL: https://img-v4.getdemo.dev/screenshot/phpstorm64_y74WDSpXx7.mp4