-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add server islands support for MDX
#12574
base: main
Are you sure you want to change the base?
Conversation
|
MDX
CodSpeed Performance ReportMerging #12574 will not alter performanceComparing Summary
|
@apatel369 any updates? |
@ematipico I applied the changes suggested by @matthewp. Tests are still failing. |
@apatel369 the PR was in draft for a long time without any updates. What suggestions are you referring to? What kind of help do you need? |
Changes
reopening #12446 for
main
Closes #12252
Server Islands are not rendering as islands in .mdx files because server islands metadata is not added for JSX components in MDX files.
Even after adding server islands metadata, the issue persists because transform function in vite-plugin-server-islands.ts file runs before server metadata is added in rehype.ts file.
I found that vite-plugin-server-islands.ts is added last in create-vite.ts and has enforce: 'post' but still transform function is running before the server meta data is added.
I am looking for feedback and guidance from Astro contributors on how to fix it.
Testing
TODO
Docs
Not needed