-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stable sessions docs #11352
base: main
Are you sure you want to change the base?
Stable sessions docs #11352
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Just a reminder that we can move the API docs to config reference in this PR for internal/link consistency, but changes will (also) have to be made in the astro repo to be pulled in here. Since this is the better authoring experience, it's fine to draft the docs here, and even keep them here, for the 5.7.0 branch! We do just have to make sure that they are eventually added to the public config types, or else we'll lose them when that file overwrites the local configuration-reference file. |
@sarah11918 to be clear, these config API changes have been authored in the Astro repo, but haven't been merged as they're part of the minor PR. I ran the docgen script so they also show up here. https://github.com/withastro/astro/pull/13527/files#diff-3919010fb2f9bfd24993b91e720147659af609f7f770c14a9aab6fb2908f5fe3R934 |
15d23c3
to
0a2f2d1
Compare
Just pushed a commit to remove the translations so that the slug check should now pass! |
I believe checks should pass (or at least, shouldn't fail as a result of translations) now. EDIT: nope! Still going... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just submitting a partial review so far because GitHub is feeling particularly slow and unreliable! 😅
Pages still to review:
/guides/sessions.mdx
/reference/api-reference.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick light editing suggestions on the api-reference page. Looks sooooo good! Great use of the tabs!
(Next up, and finally, just the sessions guide page to review)
OK @ascorbic - pushed a commit above for the API reference directly because I wanted to move headings around. (We don't need everything nexted under "basic usage" anymore because that's what this guide is now!) At the same time, I made a few light text edits, because that's all this page needs. But, do feel free to push back on those! Was just easier with so little work needed while I was in the file anyway! |
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
OK @ascorbic - I think there are only two unresolved issues here now: describing the sessions object and making sure everything is version 5.7.0 I resolved the config-reference nits because I did go check the implementation PR and I think that one looks fine. I'll check it when it's pulled in here to be sure everything worked out fine, but I think it's OK as far as content goes, and I left version comments there. |
(Oh, and there are conflicts because the translators are translating under our feet... 😅 ) |
ebdaae4
to
0a94db8
Compare
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Noting that the Vercel additions look good! No notes! 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, here's my first pass at it. Mostly nits and a few improvements on the translations.
src/content/docs/en/reference/errors/session-config-missing-error.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/ko/reference/errors/session-storage-save-error.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/pt-br/reference/errors/session-config-missing-error.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/pt-br/reference/errors/session-config-without-flag-error.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/pt-br/reference/errors/session-storage-init-error.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/pt-br/reference/errors/session-storage-save-error.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that means this one is good to go, subject only to anything last minute we notice! 🎉 (And, the inevitable docgen...)
Amazing work with this Matt! Can't wait for this to be live!
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Description (required)
Adds docs for the stable sessions feature:
session
to context API docsRelated issues & labels (optional)