Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lunaria-report-bot.ts #11

Merged
merged 8 commits into from
Mar 11, 2025
Merged

Update lunaria-report-bot.ts #11

merged 8 commits into from
Mar 11, 2025

Conversation

Adammatthiesen
Copy link
Member

@Adammatthiesen Adammatthiesen commented Mar 11, 2025

This pull request includes changes to the Discord message formatting and sending process for the Lunaria CI report. The main changes involve simplifying the code and updating the GitHub Actions workflow to use a different action for sending Discord notifications.

Improvements to Discord message formatting and sending:

  • .github/workflows/ci-report-lunaria.yml: Updated the workflow to use Ilshidur/action-discord@0.3.2 for sending Discord notifications, and removed the previous configuration that used withstudiocms/automations/.github/workflows/discord-msg.yml@main.

  • scripts/lunaria-report-bot.ts: Simplified the setDiscordMessage function by removing the filtering of the status variable and consolidating the message and embed message into a single message string. [1] [2] [3]

@Adammatthiesen Adammatthiesen marked this pull request as ready for review March 11, 2025 14:37
@Adammatthiesen Adammatthiesen requested a review from a team as a code owner March 11, 2025 14:37
RATIU5
RATIU5 previously approved these changes Mar 11, 2025
louisescher
louisescher previously approved these changes Mar 11, 2025
Copy link
Member

@louisescher louisescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, nice changes though

Co-authored-by: Louis Escher <66965600+louisescher@users.noreply.github.com>
@Adammatthiesen Adammatthiesen dismissed stale reviews from louisescher and RATIU5 via a2336c1 March 11, 2025 14:40
@Adammatthiesen Adammatthiesen merged commit a1b8bd6 into main Mar 11, 2025
5 checks passed
@Adammatthiesen Adammatthiesen deleted the Adammatthiesen-patch-1 branch March 11, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants