sanity checks on message types during rekey

[JacobBarthelmeh]

ZD18338

[Copilot]

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)

• src/internal.c: Language not supported
• wolfssh/internal.h: Language not supported

[JacobBarthelmeh]

Retest this please Jenkins

[Copilot]

Pull Request Overview

This PR adds sanity checks on message types during rekey operations by introducing new macros and updating error handling logic across various modules. Key changes include:

• Addition of WS_MSG_SEND and WS_MSG_RECV macros in wolfssh/internal.h.
• Refactored error handling logic in several functions (e.g., replacing explicit WS_WANT_READ/WS_WANT_WRITE checks with NoticeError calls) and updated rekeying condition handling.
• Updates in helper functions and example applications to incorporate the new rekeying checks.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
wolfssh/internal.h	Added new macros WS_MSG_SEND and WS_MSG_RECV with an accompanying comment.
src/wolfsftp.c	Modified error handling using NoticeError, improving rekey error management.
src/ssh.c	Added rekeying checks in stream read/send and channel read functions.
src/internal.c	Updated IsMessageAllowed signature to accept a new state parameter and added keying checks.
examples/sftpclient/sftpclient.c	Incorporated rekey state recovery logic in the autopilot command loop.
examples/client/client.c	Adjusted rekeying error handling in input and peer reading functions.