Skip to content

Improve sniffer detection of partial overlap #9140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

Improve sniffer detection of partial overlap #9140

merged 1 commit into from
Sep 3, 2025
+20 −58

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Aug 26, 2025

Description

Improve detection of partial overlap (ZD 20369)
Improves on PR #9124

Testing

Customer supplied .pcap.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske dgarske self-assigned this Aug 26, 2025
@devin-ai-integration Devin.ai Integration
Copy link
Contributor

🛟 Devin Lifeguard found 1 likely issues in this PR

  • pointer-null-check snippet: Verify whether session->sslServer and session->sslClient are guaranteed non-NULL when AdjustSequence is called; if not, add if (ssl != NULL && ssl->buffers.inputBuffer.length > 0) to protect the dereference.

@dgarske
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

@dgarske dgarske force-pushed the sniffer_partialoverlap branch 3 times, most recently from cb36990 to 9abe3a0 Compare August 29, 2025 23:23
@dgarske dgarske force-pushed the sniffer_partialoverlap branch from 9abe3a0 to 6dd626d Compare September 2, 2025 14:51
@dgarske dgarske assigned wolfSSL-Bot and unassigned dgarske Sep 3, 2025
@dgarske dgarske requested a review from lealem47 September 3, 2025 20:04
lealem47
lealem47 approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@lealem47 lealem47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dgarske !

@lealem47 lealem47 merged commit e29b65d into wolfSSL:master Sep 3, 2025
328 of 331 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lealem47 lealem47 lealem47 approved these changes

Assignees

@wolfSSL-Bot wolfSSL-Bot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgarske @lealem47 @wolfSSL-Bot