-
Notifications
You must be signed in to change notification settings - Fork 131
[Android SDK update] Target SDK to 35 #13334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…partially covers subtitile
…t: ViewArticleActivity, RequestActivity, RequestListActivity
…tivity [Android SDK] Edge to edge ViewArticleActivity
[Android SDK] Edge-to-edge to WooLogViewer activity
…terActivity [Android SDK] Edge to edge help center activity
…AboutScreenActivity [Android SDK] Edge to edge UnifiedAboutScreenActivity
[SDK35 Update] Make POS screens scrollable with keyboard open
Applies to some SDK activities like the `SignInHubActivity` used in Google sign in.
…r-crash [SDK 35] Fix NPE crash related to ApiFaker
…rt-for-contact-form Issue/android 35 ime support for contact form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great teamwork! All previous issues have been addressed. I only noticed keyboard issues on two more screens. Additionally, I assume we’ll need another test round after upgrading the targetSdk to 35.
1. Send feedback screen

2. Connect Jetpack screen
The password screen works well. There is an issue only on the email screen.

thanks @irfano for the test, I'll take a look at both issues |
In MainActivity we handle the `ime` insets, and then consume all insets, so it means we shouldn't need to consume them again. And because of a bug in Compose, the insets get consumed twice leading to UI issues.
Fix issues related to edge-to-edge and IME handling
@irfano we merged the fix here! Please take a look again I am AFK tomorrow. If it's looks good for you, please go ahead with merging! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes @hichamboushaba! LGTM! 👍🏻
Closes: #13270
Description
Feature branch with all the changes performed to support target SDK 35. The code has been reviewed already
Steps to reproduce
Testing information
Whole app regression
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: