Skip to content

[Android SDK update] Target SDK to 35 #13334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 169 commits into from
Apr 29, 2025

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Jan 16, 2025

Closes: #13270

Description

Feature branch with all the changes performed to support target SDK 35. The code has been reviewed already

Steps to reproduce

Testing information

Whole app regression

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@dangermattic
Copy link
Collaborator

dangermattic commented Jan 16, 2025

3 Warnings
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ Class MainActivityEdgeToEdgeHelper is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class ApplicationEdgeToEdgeEnabler is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 16, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit6ddb40e
Direct Downloadwoocommerce-wear-prototype-build-pr13334-6ddb40e.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 16, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit6ddb40e
Direct Downloadwoocommerce-prototype-build-pr13334-6ddb40e.apk

Base automatically changed from 13269-android-sdk-update-min-sdk-to-35 to trunk January 16, 2025 16:58
@kidinov kidinov linked an issue Jan 16, 2025 that may be closed by this pull request
@kidinov kidinov added this to the 21.7 milestone Jan 27, 2025
JorgeMucientes and others added 3 commits April 16, 2025 17:42
[SDK35 Update] Make POS screens scrollable with keyboard open
Applies to some SDK activities like the `SignInHubActivity` used in Google sign in.
@kidinov kidinov modified the milestones: 22.2, 22.3 Apr 17, 2025
@kidinov kidinov requested a review from irfano April 18, 2025 06:52
Copy link
Contributor

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great teamwork! All previous issues have been addressed. I only noticed keyboard issues on two more screens. Additionally, I assume we’ll need another test round after upgrading the targetSdk to 35.

1. Send feedback screen

2. Connect Jetpack screen

The password screen works well. There is an issue only on the email screen.

@hichamboushaba
Copy link
Member

thanks @irfano for the test, I'll take a look at both issues

@kidinov kidinov requested a review from irfano April 23, 2025 18:55
@kidinov
Copy link
Contributor Author

kidinov commented Apr 23, 2025

@irfano we merged the fix here! Please take a look again

I am AFK tomorrow. If it's looks good for you, please go ahead with merging!

@kidinov kidinov requested a review from hichamboushaba April 28, 2025 05:46
Copy link
Contributor

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes @hichamboushaba! LGTM! 👍🏻

@irfano irfano merged commit 9844cbf into trunk Apr 29, 2025
17 checks passed
@irfano irfano deleted the 13270-android-sdk-update-target-sdk-to-35 branch April 29, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android SDK] Update target SDK to 35