Skip to content

Support for starred packages on Carrier tab #13978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JorgeMucientes
Copy link
Contributor

@JorgeMucientes JorgeMucientes commented Apr 25, 2025

Closes: WOOMOB-320

Description

Adds UI component for starring/un-starring carrier packages in shipping labels flow.

Note that these changes don't include updating the starred status in the backend side, only at the UI/ViewModel level

Testing information

  1. Log into a site with shipping labels enabled.
  2. Open the orders tab.
  3. Tap on an order eligible for shipping label creation. It’s better to choose one with multiple items.
  4. Tap on Create shipping label.
  5. Tap on Select Package
  6. Select Carrier tab
  7. Tap to star/unstar carrier packages. Check selection survives device rotation.

The tests that have been performed

The above

Images/gif

starredCarrierPackage.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 25, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit6898505
Direct Downloadwoocommerce-wear-prototype-build-pr13978-6898505.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 25, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit6898505
Direct Downloadwoocommerce-prototype-build-pr13978-6898505.apk

@JorgeMucientes JorgeMucientes changed the title Issue/woomob 320 add UI to starunstar saved packages Support for starred packages on Carrier tab Apr 28, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 3.03030% with 32 lines in your changes missing coverage. Please review.

Project coverage is 38.20%. Comparing base (b4a7784) to head (b1ca105).
Report is 202 commits behind head on trunk.

Files with missing lines Patch % Lines
...abels/packages/components/PackageItemComponents.kt 0.00% 17 Missing ⚠️
...ckages/WooShippingLabelPackageCreationViewModel.kt 0.00% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13978      +/-   ##
============================================
- Coverage     38.21%   38.20%   -0.01%     
+ Complexity     9415     9414       -1     
============================================
  Files          2112     2112              
  Lines        116436   116464      +28     
  Branches      14884    14890       +6     
============================================
  Hits          44497    44497              
- Misses        67890    67917      +27     
- Partials       4049     4050       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JorgeMucientes JorgeMucientes added this to the 22.3 milestone Apr 29, 2025
@JorgeMucientes JorgeMucientes added the feature: shipping labels Related to creating, ordering, or printing shipping labels. label Apr 29, 2025
@JorgeMucientes JorgeMucientes marked this pull request as ready for review April 29, 2025 11:01
@irfano irfano self-assigned this Apr 29, 2025
Copy link
Contributor

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻 It works as expected. Good to merge after addressing the minor feedback I added.

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 22.3. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@JorgeMucientes JorgeMucientes merged commit 5099005 into trunk Apr 30, 2025
17 checks passed
@JorgeMucientes JorgeMucientes deleted the issue/woomob-320-add-ui-to-starunstar-saved-packages branch April 30, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants