-
Notifications
You must be signed in to change notification settings - Fork 131
Support for starred packages on Carrier tab #13978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for starred packages on Carrier tab #13978
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13978 +/- ##
============================================
- Coverage 38.21% 38.20% -0.01%
+ Complexity 9415 9414 -1
============================================
Files 2112 2112
Lines 116436 116464 +28
Branches 14884 14890 +6
============================================
Hits 44497 44497
- Misses 67890 67917 +27
- Partials 4049 4050 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻 It works as expected. Good to merge after addressing the minor feedback I added.
Closes: WOOMOB-320
Description
Adds UI component for starring/un-starring carrier packages in shipping labels flow.
Note that these changes don't include updating the starred status in the backend side, only at the UI/ViewModel level
Testing information
The tests that have been performed
The above
Images/gif
starredCarrierPackage.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: