-
Notifications
You must be signed in to change notification settings - Fork 131
[WOOPRD-466][Woo POS][Product search] Implement search input based on the design #13980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WOOPRD-466][Woo POS][Product search] Implement search input based on the design #13980
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13980 +/- ##
============================================
- Coverage 38.31% 38.30% -0.02%
- Complexity 9495 9496 +1
============================================
Files 2116 2116
Lines 116389 116422 +33
Branches 14918 14919 +1
============================================
+ Hits 44591 44592 +1
- Misses 67715 67748 +33
+ Partials 4083 4082 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…search-input-based-on-the
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes: #WOOPRD-466
Description
Changes the UI of the search input based on the design. It's maybe not final so lets not merge it yet
The clear is standard from the library(used another one)I asked Wagner regarding this pdfdoF-6XY-p2#comment-8073 ✅
WSViBnnZyFv39tpr9v1gVy-fi-2128_21295
Steps to reproduce
Testing information
Images/gif
04-28--14-35.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: