Skip to content

[WOOPRD-466][Woo POS][Product search] Implement search input based on the design #13980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Apr 28, 2025

Closes: #WOOPRD-466

Description

Changes the UI of the search input based on the design. It's maybe not final so lets not merge it yet

  • Font is smaller otherwise it's cut off by the internal input paddings ✅
  • The clear is standard from the library (used another one)

I asked Wagner regarding this pdfdoF-6XY-p2#comment-8073 ✅

WSViBnnZyFv39tpr9v1gVy-fi-2128_21295

Steps to reproduce

  • Open POS
  • Open Search
  • Validate the search input design in dark and light mode

Testing information

  • Animation is slightly broken, but as we need to change it anyway, I decided not to spend time on fixing

Images/gif

04-28--14-35.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov added status: do not merge Dependent on another PR, ready for review but not ready for merge. category: design Layout and style elements in the UI or user interface, including color and animations. feature: POS labels Apr 28, 2025
@kidinov kidinov added this to the 22.3 milestone Apr 28, 2025
@kidinov kidinov requested a review from samiuelson April 28, 2025 12:37
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 28, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitc5a625e
Direct Downloadwoocommerce-wear-prototype-build-pr13980-c5a625e.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 28, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitc5a625e
Direct Downloadwoocommerce-prototype-build-pr13980-c5a625e.apk

@kidinov kidinov removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Apr 29, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 112 lines in your changes missing coverage. Please review.

Project coverage is 38.30%. Comparing base (91dc1f2) to head (c5a625e).
Report is 9 commits behind head on trunk.

Files with missing lines Patch % Lines
...os/common/composeui/component/WooPosSearchInput.kt 0.00% 112 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13980      +/-   ##
============================================
- Coverage     38.31%   38.30%   -0.02%     
- Complexity     9495     9496       +1     
============================================
  Files          2116     2116              
  Lines        116389   116422      +33     
  Branches      14918    14919       +1     
============================================
+ Hits          44591    44592       +1     
- Misses        67715    67748      +33     
+ Partials       4083     4082       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samiuelson samiuelson self-assigned this Apr 29, 2025
Copy link
Contributor

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@samiuelson samiuelson enabled auto-merge April 29, 2025 10:23
@samiuelson samiuelson merged commit 5fb8ef9 into trunk Apr 29, 2025
18 checks passed
@samiuelson samiuelson deleted the wooprd-466-woo-posproduct-search-implement-search-input-based-on-the branch April 29, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations. feature: POS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants