Skip to content

[WOOPRD-471][Woo POS][Product search] Do the design changes for empty query screen #13984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Apr 29, 2025

Closes: #WOOPRD-471

Description

  • Changes amount of the items we show to 10
  • Adds closing the keyboard when scrolled
  • Removed the icon, changed padding for the titles (it's 16 not 20 as in the design right ow as 20 is not in the DS)

Steps to reproduce

  • Open POS
  • Click on search
  • Validate the changes
  • Compare with the design
image

WSViBnnZyFv39tpr9v1gVy-fi-135_8101

The tests that have been performed

Images/gif

04-29--09-46.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov added this to the 22.3 milestone Apr 29, 2025
@kidinov kidinov requested a review from samiuelson April 29, 2025 07:47
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 29, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitb4c0ea2
Direct Downloadwoocommerce-wear-prototype-build-pr13984-b4c0ea2.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 29, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitb4c0ea2
Direct Downloadwoocommerce-prototype-build-pr13984-b4c0ea2.apk

@samiuelson samiuelson self-assigned this Apr 29, 2025
Copy link
Contributor

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@samiuelson samiuelson enabled auto-merge April 29, 2025 10:04
kidinov added 2 commits April 30, 2025 15:29
…ign-changes-for-empty-query

# Conflicts:
#	WooCommerce/src/main/res/values/strings.xml
…-do-the-design-changes-for-empty-query' into wooprd-471-woo-posproduct-search-do-the-design-changes-for-empty-query
@kidinov kidinov disabled auto-merge April 30, 2025 13:31
@kidinov kidinov enabled auto-merge April 30, 2025 13:31
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 22.3. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@kidinov kidinov merged commit 13d4b26 into trunk May 1, 2025
17 checks passed
@kidinov kidinov deleted the wooprd-471-woo-posproduct-search-do-the-design-changes-for-empty-query branch May 1, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants