Cache enabled payment method IDs for non-admin pages #4183
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrosa
reviewed
Apr 2, 2025
changelog.txt
Outdated
| @@ -43,6 +43,7 @@ | |||
| * Tweak - Add save payment method parameter to update intent call for non-deferred intent payment methods. | |||
| * Dev - Fetch Stripe settings with Stripe configuration API. | |||
| * Add - Hook up payment methods configuration. | |||
| * Dev - Cache enabled payment method IDs | |||
There was a problem hiding this comment.
I think we should explain the change better here 👀
wjrosa
reviewed
Apr 2, 2025
| @@ -84,6 +95,7 @@ public static function get_upe_enabled_payment_method_ids() { | |||
| } | |||
| } | |||
|
|
|||
| set_transient( self::UPE_ENABLED_PAYMENT_METHOD_IDS_TRANSIENT_KEY, $enabled_payment_method_ids, DAY_IN_SECONDS ); | |||
There was a problem hiding this comment.
Maybe we should include a cache bust function when the merchant changes the available payment methods.
Thanks for working on this! I could not find any indication on my debug.log file related to the cache setting/querying 🤔 . Maybe some testing steps are missing from the instructions? |
…to add/hook-up-enabled-payment-methods
…to add/hook-up-enabled-payment-methods
…to add/hook-up-enabled-payment-methods
…to add/hook-up-enabled-payment-methods
…bled-payment-methods
📈 PHP Unit Code Coverage Report
|
Base automatically changed from
add/hook-up-enabled-payment-methods
to
add/settings-synchronization
April 8, 2025 14:11
|
Closing in favor of #4241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4182
Changes proposed in this Pull Request:
This PR caches enabled payment method IDs. Frontend uses the cache if it’s set, and the backend updates the cache.
Testing instructions
dev/cache-enabled-payment-methods-testChangelog entry
Changelog Entry Comment
Comment
Post merge