[pull] master from project-chip:master #675
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Fix MRP baseTimeout calculation when it is possible the other end fall asleep * use min(SAI, SII) for mrp timeout when clock runs into idle * Restyled by clang-format * update mrp calculation -- Use 15 seconds to determine whether device is in LIT mode, then if yes, set the timeout base as SAI if GetRemoteMRPConfig().mIdleRetransTimeout.count() > sitIcdSlowPollMaximum.count() * Address comments * address comments * Restyled by whitespace * address comments * Restyled by whitespace * Restyled by clang-format * Update src/transport/UnauthenticatedSessionTable.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/transport/Session.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/protocols/secure_channel/CASESession.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/transport/SecureSession.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/protocols/secure_channel/CASESession.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/ReadClient.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/messaging/ReliableMessageProtocolConfig.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/messaging/ReliableMessageProtocolConfig.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * address comments * address comments * update true isFirstMessageOnExchange for all ComputeRoundTripTimeout caller * Restyled by whitespace * Restyled by clang-format * fix compilation error * address comments * cleanup * add parameter isFirstMessageOnExchange in GetMessageReceiptTimeout * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Integrate camera apps with vscode * Restyled by whitespace * Restyled by prettier-json * Update camera controller name to match vsvode filter --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Camera AV Stream Management Server Impl
* Delegate definition
- Support for list entries per index
- Support for Command handlers
* Server Impl
- Attributes and Commands support
-- Setters for Application to update values
* Add attributes to json files
* Autogen code changes to zzz_generated/
* Add Optional Attributes support
* Add support logic for writable attributes.
Modify feature checks for the attributes depending on their optionality
and feature categories.
* Remove some attributes to simplify AVStreamMgmt cluster slightly.
Attributes related to White balance, ShutterSPeed, ISO and Depth sensor
were removed based on feedback at the Nov member meeting.
Also, adjustments for read/write mode changes for certain attributes.
* Remove redundant CurrentSnapshotConfig and CurrentVideoCodecs attributes
Fix name of MaxFramRate in Snapshot Allocation functions.
* Add write support for ImageRotation, ImageFlipHorizontal and ImageFlipVertical attributes.
* Add handler for the SetStreamPriorities command.
* Retrieve persistent attributes from storage during initialization.
* Miscellaneous syntactic fixes to CameraAVStreamMgmt.
* Add persistence for Viewport struct attribute
* Make CameraAVStreamMgmt handle list attributes inside cluster server implementation.
Add Getter functions for cluster attributes.
* Add Delegate functions for loading pre-allocated streams.
Add persistence support for the ranked video stream priorities
attribute.
* Doc updates and adjustments based on latest Spec changes.
* Address review comments.
* Make watermark and OSD optional args.
* Fix
* Add feature and optional flags check in Init
* Modify SetStreamPriorities
* Add error handling for command params.
* Add CameraAvStreamMgmt cluster partially inside all-clusters-app.zap config
Make the snapshot attributes and commands of the CameraStreamMgmt
cluster be part of the all-clusters-app(in a minimalistic way) to
exercise the cluster.
* Add more constraint checking for command params.
Add a delegate notification callback for attribute changes.
Address other review comments.
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Restyle fixes.
* Add CameraAVStreamMgmt cluster to EP1 of camera-app.zap.
* Remove Enum validation functions.
* Address review comments
- Add endpoint id to logs.
- Add missing constraint checks.
* Various Fixes
- Remove usage of DefaultStorageAllocator for the TLV encoded stored
attributes, and replace them with SafeWriteValue()/SafeReadValue()
APIs from GetSafeAttributePersistenceProvider.
- Make the RankedStreamPriorities a vector and handle the TLV encoding
of the list of enums.
- Populate the CaptureSnapshot response properly with image data
received from delegate.
* Add parameters struct for housing the set of stream allocation parameters for the delegate.
* Add initial delegate implementation in all-clusters-app.
* Update Camera AVStreamMgmt Server SDK based on Spec changes from Spec PR#11309.
* Update all-clusters-app and camera-app with attribute changes.
* Updates to CameraAVStreamMgmt delegate.
* Fix Command de-allocation comments.
* Fix Command code numbering in zap file.
* Add SnapshotStreamModify command support.
* Fix persisted storage handling for Viewport and STream Priorities.
* Address review comments.
* Resolve conflicts in all-clusters-app.matter and camera-app.matter.
* Update src/app/clusters/camera-av-stream-management-server/camera-av-stream-management-server.h
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Address review comments.
---------
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
…TC-DGWIFI-2.2 (#37957) Signed-off-by: Oliver Fan <oliver.fan@nxp.com>
… "Update branch" feature being used too often (#38009) * CONTRIBUTING: Add a note discouraging unneccessary CI runs due to the "Update branch" feature being used too often Signed-off-by: Maciej Grela <m.grela@samsung.com> * Restyled by prettier-markdown * Update CONTRIBUTING.md Restore proper tip formatting according to GitHub Markdown manual. Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com> * Update CONTRIBUTING.md * restyled: restyled release now ships restyler-linux-x86_64 properly now Signed-off-by: Maciej Grela <m.grela@samsung.com> * Restyled by prettier-markdown --------- Signed-off-by: Maciej Grela <m.grela@samsung.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com>
github-actions
bot
added
the
documentation
Description: - TestInetEndPoint was not hermetic, it required at least one network interface connected to a link and up. - There was a comment before to skip tests if the link was not up, but it was not actually skipping the test. This made it fail for me when working offline and trying to run unit tests. Testing done: - Test passes with and without link up.
This fixes an error:
src/app/server/Server.cpp:621:34: error: call to implicitly-deleted default constructor of 'DeviceLayer::ChipDeviceEvent'
621 | DeviceLayer::ChipDeviceEvent event;
| ^
src/include/platform/CHIPDeviceEvent.h:508:11: note: default constructor of 'ChipDeviceEvent' is implicitly deleted because variant field 'CHIPoBLEConnectionError' has a non-trivial default constructor
508 | } CHIPoBLEConnectionError;
| ^
1 error generated.
* Use OPENTHREAD instead of OPEN_THREAD * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
…38053) * Postpone `RevertConfiguration` until Server is initialized. * Clear SRP host and services before reverting dataset. * Abort revert if creating new backup. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…ement in 1.5 (#37902) * Basic energy-gateway-app framework for Linux and ESP32 - linking issue due to device type problems bringing in expected clusters. * Initial attempt to add new clusters based of PR 10815 - ZAP is raising error 'Unable to find cluster extension by component' * Added missing xml files to zcl.json. Added regen of global-structs.xml and global-enums.xml (NOTE: ApparentPowerThresholds SHOULD be power_mva! but Zap does not recognise this yet. * Temporary change of "money" to int64s whilst waiting for a ZAP change. * Added Meter Identification cluster XML * Updated tests.yaml and rules.matterlint to include new clusters * .matter file updates caused by new enums * Updated files after zap_regen_all * New files after zap_regen_all * Add support for money and new electrical data types * Added new attributes for structs to attributeAccessInterfaceAttributes. Removed legacy measurement-and-sensing.xml in favour of new global-structs/global-enums.xml * Updated .matter files after subsequent regen_all * code autogen after moving to global structs/enums and updating structs in attributes- regen_all * Backed out change to support SetVidVerificationStatement etc * Enabled Commodity Price in data_model/contoller-clusters.zap. Added stub basic-type Currency. Disabled Ember in config-data.yaml. Linux now builds but aborts at start-up. * Update chip-types.xml with new energy types and money * Changed to use correct global struct CurrencyStruct * Revert changes to generated attribute-type.h file * regen_all after merging in Hasty's new types PR: #37980 * Further zap_regen_all updates after picking up fix from Hasty#s #37980 * Revert reversion of generated attribute-type.h * Fix build issue due to moving MeasurementAccuracyStruct to global-structs. * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Update attribute-type.h * Fix EEM/EPM clusters which use new global MeasurementAccuracyRangeStruct and MeasurementTypeEnum * Restyled by clang-format * Generated XML files from Alchemy for new clusters and refreshed older EM clusters with latest Alchemy. * Added missing zap_cluster_list.json * Added missing CurrencyStruct * zap_regen_all * Fix-up EEM/EPM and apps that use them because the Structs and Enums have moved to Globals:: namespace * Fix CI issue - Re-did bootstrap to pick up new ZAP, and regen_all. Updated ChipStructs.java which was different in CI * Reverted back to using existing measurement-and-sensing-.xml to avoid API backwards compatibility change. * Regen_all to revert all .matter files back to remove global MeasurementType enum * Another regen_all * Manually added missing description to the clusters to hopefully fix the IDL parsing errors. * Regen_all to include description tag from XML. * Updated ChipStructs.java after previous regen_all * Revert bad merge * Reverted removal of measurement and sensing xml * regen_all * Moved MatterCommodityPricePluginServerInitCallback() to util.cpp to resolve linker error * Reverted ElectricalPowermeasurementDelegate use of global struct * Bump zap to 2025.3.25 * Partial regen-all to update .matter files (zap-regen-all still crashes!) * Support non-nightly versions * Another update for logic * Fix bad update * Update one more extra extension * Reverted some of the xml files that were updated by alchemy and not really needed in this pr * Reverted EEM/EPM xml files * Zap regen all finally fixed with increased timeout * Merge of .github/workflows/tests.yaml had screwed up * Fixed Linux crash on startup by adding an empty cmd handler function for now and calling ChipLinuxAppInit() * Revert "Merge remote-tracking branch 'andrei/zap_update' into energy-gateway-app" This reverts commit 0cc1dea, reversing changes made to 2fd6786. * Syncd back to Master after reverting Andrei's zap changes * Per review comment - changed copyright to only 2025 * Updated more copyright to 2025 * Update copyright commodity-price-server.cpp --------- Co-authored-by: Hasty Granbery <hasty@granbery.org> Co-authored-by: Hasty Granbery <granbery@google.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Andrei Litvin <andreilitvin@google.com>
* Update versions * Updating devices * Added Ota Requestor * Adding matter file
* Make MTRServerEndpoint threadsafe. If two API clients are both touching the same instance of MTRServerEndpoint on different threads, we should handle that correctly. Fixes #31756 * Fix deadlock due to recursive locking in MTRServerEndpoint.
…rovideOfferResponse command (#38253) * Create a new WebRTCSessionStruct upon receiving ProvideOfferResponse Command * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
…ction (#38280) * reporting: Remove the weak MatterReportingAttributeChangeCallback function * Remove exception for BUILD.gn excluding things * try to fix test builds --------- Co-authored-by: Andrei Litvin <andy314@gmail.com>
* adds RockBitmap values constraint to RockSupport and RockSetting attributes * restyled * update * Update src/app/tests/suites/certification/Test_TC_FAN_2_3.yaml Co-authored-by: Rob Bultman <rob.Bultman@gmail.com> * updates RockSupport conformance * updates RockSupport minValue * updates constraints * restyled * ports to python * renames variables * typo * update skip message * updates rock feature check * updates copyright year --------- Co-authored-by: Rob Bultman <rob.Bultman@gmail.com>
* Bump third_party/pigweed/repo from `8ffdd15` to `0c348e1` Bumps [third_party/pigweed/repo](https://github.com/google/pigweed) from `8ffdd15` to `0c348e1`. - [Commits](google/pigweed@8ffdd15...0c348e1) --- updated-dependencies: - dependency-name: third_party/pigweed/repo dependency-version: 0c348e1c1632b30315c501764a2cbb9053f79e1d dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Fix cast that gets flagged by latest clang * Reset pigweed to before unit test depending on sync * Remove some warnings from tidy for tests --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrei Litvin <andy314@gmail.com> Co-authored-by: Andrei Litvin <andreilitvin@google.com>
…ports (#38065) * Initial delegate for camera-app. * Add camera-hal interface. * Camera App changes - Define Camera HAL interface inside camera-device-interface.h. - Move stream handling logic from AVStream Delegate to inside CameraDevice. - Add initial Gstreamer support inside CameraDevice for stream start/stop. * Add camera-av-stream-manager.h header * Remove camera-hal.h since the interface methods are integrated into camera-device-interface.h. * Fixes to gstreamer pipelines and Camera AVStreamManager Init * Add ResourceExhausted error return for StreamAllocate functions. * Restyle fixes * Refactor snapshot pipeline. -Add separate snapshot pipeline creation helper function. -Have stream started at Init. -Capture snapshot reads latest copy of image file. * Remove glib-2.0 from dependencies. --Also ensure the resolution values of the correct snapshot stream id is returned in the CaptureSnapshot response. * Use pkg_config to configure BUILD.gn for gstreamer instead of manually including headers and libs. * Add initial media controller and transport interface headers. * Add NetworkStreamSource and MediaController logic. NetworkStreamSource is used to source each stream from a network source and distribute to the media controller. MediaController multiplexes the stream to registered transports that are ready to receive it. Separate out stream source distribution to transports based on type. * Add more checks to stream allocation functions. * Move stream allocation/de-allocation function logic from HAL interface to CameraAVStreamManager. Streams are pre-allocated by CameraDevice(implementer of HAL) and allocation/de-allocations are managed by camera-av-stream-mgmt. Camera-av-stream-mgmt uses HAL interface to start/stop streams. * Address review comments. - Loop on select on the socket with small sleeps on timeout. - Make the CameraDevice not be a singleton and use a setter on CameraAVStreamManager to set it, so that the HAL functions can be accessed via the member CameraDevice object instead of a singleton GetIntance() reference. - Move the Stream struct definitions into the CameraHAL with a context pointer to hold platform-specific stream context(e.g., GstElement) - Make the transportActive bool atomic. - Define utility method for streams to compare allocation parameters. * Update linux standalone yaml to latest Docker version. Also update Log module to `Camera` in the camera-app. * Remove snapshot file when stream is deallocated and other fixes. -Add `override` keyword to implemented delegate methods. -Directly access stream vector from HAL in loop. -Remove unnecessary gst header inclusion.
…framework. (#38303) Still only allow one transfer per node, but stop restricting to one transfer per controller.
Error was:
```
../../src/crypto/tests/TestChipCryptoPAL.cpp:1573:38: note: Access of 'csr' at negative byte offset -2
1573 | csr[length - 2] = (uint8_t) (csr[length - 2] + 1);
| ^~~~~~~~~~~~~~~
WARNING TIDY ../../src/crypto/tests/TestChipCryptoPAL.cpp: 1 warning treated as error
WARNING Tidy ../../src/crypto/tests/TestChipCryptoPAL.cpp ended with code 1
```
Cause was that a EXPECT was used where ASSERT should be used, which leads to
an access in mbedTLS unit test version, that should not have run.
…tter.framework tests. (#38306)
…oad flag. (#38293) Before dispatching for payload processing, ensure that a received command that is flagged with the `L` quality is on an Exchange over a LargePayload session.
* Implement Audio Video source pipelines. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Rebase code on latest master. Signed-off-by: Raveendra Karu <r.karu@samsung.com> --------- Signed-off-by: Raveendra Karu <r.karu@samsung.com>
…tic temperature levels (temperature control cluster) endpoint agnostic. (#38142) * Chef: Add APIs to provide deviceType info on Endpoints. Fix composition initialization in attribute storage. * + * + * Fix: two elements should not have common bits in an enum used as bitmask * Restyled by clang-format * Refactoring * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * compilation err * + * Rename DataModelUtils to DeviceTypes * Document the new methods * Fix invalid memory. * Fix compilation * Comments for EndpointPair struct. New chef namespace for cluster configuration. * + * Do not silently ignore CHIP_ERROR return value * Review suggestion * Review suggestion * Use Enums for expected endpoint IDs * Avoid enums due to casting issue * Use Span for temperature levels * Use Span for temperature levels * Fix compilation * nit: Rename constant. --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Copy&paste from project settings to xcconfig * Handle settings where [config=X] does not work via separate files * Move additional settings into Debug/Release file * Move some identical settings up to Project.xcconfig * Include override xcconfig files if present * Consolidate some settings between Debug and Release builds - darwin-framework-tool had HEADER_SEARCH_PATHS defined in a different order - Tidy up GCC_PREPROCESSOR_DEFINITIONS These changes make build logs no longer exactly identical (only equivalent) * Add Debug/Release config files for Matter and dft in case we need to override config-specific settings * Align warning settings between targets, organize project settings * Tidy up / organize some more settings - SDKROOT does not need to be selected manually - INSTALLHDRS_SCRIPT_PHASE = YES is only needed for TAPI_ENABLE_PROJECT_HEADERS - Refactor OTHER_LDFLAGS for Matter framework, link Security framework via LDFLAGS instead of a project setting * Add override files to the Xcode project so they are visible if they exist * Fix availability check to include iOS version * Fix and organize darwin-framework-tool build settings
* Rename DM xml Master to 1.5_in_progress This will allow me to add data model files for master with all in-progress includes to support 1.6 development. * Update 1.5 to new alchemy * Add master as a copy of 1.5 in progress * Update master to ToT as of April 8 * Update build file
This fixes replacement logic to support both nightly and non-nightly properly.
Should make it easier to write tests.
…#38147) * Updating closure server code as per new specification update * Update examples/closure-app/closure-common/closure-control/src/ClosureControlDelegateImpl.cpp Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com> * Update src/app/clusters/closure-control-server/closure-control-server.h Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com> * Update examples/closure-app/closure-common/closure-control/include/ClosureControlDelegate.h Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com> * addressing PR commits * addressing PR commits * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: sabollim <satyanaag.bollimpalli@silabs.com> Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: senthilku <senthil.kumar@silabs.com>
* Add VidVerification payload generation to CHIPCryptoPAL
This PR:
- Adds necessary crypto primitives for VID Verification,
which will be used by later PRS
- Adds the necessary unit tests based on spec test vectors.
Testing done:
- Added unit test coverage for the new code, matching
independent test vectors in spec.
* Restyled by clang-format
* Apply review comments
* Restyled by clang-format
* Fix unit test static analyzer warning
Error was:
```
../../src/crypto/tests/TestChipCryptoPAL.cpp:1573:38: note: Access of 'csr' at negative byte offset -2
1573 | csr[length - 2] = (uint8_t) (csr[length - 2] + 1);
| ^~~~~~~~~~~~~~~
WARNING TIDY ../../src/crypto/tests/TestChipCryptoPAL.cpp: 1 warning treated as error
WARNING Tidy ../../src/crypto/tests/TestChipCryptoPAL.cpp ended with code 1
```
Cause was that a EXPECT was used where ASSERT should be used, which leads to
an access in mbedTLS unit test version, that should not have run.
* Disable a non-applicable clang-tidy
---------
Co-authored-by: Restyled.io <commits@restyled.io>
…38326) * Create a current copy of all_clusters * Test generators golden image recreate * Also update lighting app
* Consolidate mock device type generation functions This affects only unit tests, both are run in the CI. Pre-req for some upcoming device type check additions. * Restyled by isort * linter * omit fake device builder from the CI --------- Co-authored-by: Restyled.io <commits@restyled.io>
…d of just one (#37931) * Add support for a server cluster interface to service multiple paths. This fixes #37928 * more tests and restyle * Review update * one more review rename * self review: fix include quoting * Self review: remove unused include * self review: fix logic of listing clusters as we want no duplicates * Restyle * one more unit test * Fix test * Restyled by clang-format * Fix cleanup in test * Restyled by clang-format * update to make darwin compiler happy * Enforce server cluster interface registrations for the codegen provider to share the same endpoint * Fix logic to not try to use temporary (even if it was probably safe) * Restyle * Fix include * Update src/app/server-cluster/ServerClusterInterface.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/server-cluster/ServerClusterInterface.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/server-cluster/ServerClusterInterface.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/server-cluster/ServerClusterInterface.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/server-cluster/ServerClusterInterface.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/server-cluster/ServerClusterInterface.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/server-cluster/ServerClusterInterface.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/server-cluster/ServerClusterInterface.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/server-cluster/ServerClusterInterface.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/server-cluster/ServerClusterInterface.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/data-model-providers/codegen/CodegenDataModelProvider.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Move PathContains into cpp source * Fix cmake dependencies now that we added a non-inline file * Add server-cluster files to xcode project * Disable new clangtify error - we do not want to check for uncounted members in the CPP code * Fix clang-tidy error skip: add comma * Use a group path for the server-cluster directory in the matter framework * Add server cluster sources to darwin-frameworktool. Oddly enough I am unclear where in the UI this comes from so did a manual edit... --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* adds wind attributes constraints * Update src/app/tests/suites/certification/Test_TC_FAN_2_4.yaml Co-authored-by: Rob Bultman <rob.Bultman@gmail.com> * updates WindSetting validation * updates constraints * restores yaml, will port to python * python port * restyled * updates step skipping * updates wind feature check * updates steps * removes Test_TC_FAN_2_2 from ciTests.json (leftover from another PR) * adds wirte/read wind setting steps * updates step 5 * restyled --------- Co-authored-by: Rob Bultman <rob.Bultman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )