Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana: adjustments to proposals #10

Merged
merged 4 commits into from
Mar 21, 2024
Merged

solana: adjustments to proposals #10

merged 4 commits into from
Mar 21, 2024

Conversation

deekerno
Copy link
Contributor

Description

This PR makes a few adjustments to the proposals workflow.

Testing Steps

Tests should pass.

@deekerno deekerno requested review from a5-pickle and gator-boi March 14, 2024 20:03
@deekerno deekerno force-pushed the solana/fix-proposals branch from 05f6c7c to 6f60709 Compare March 15, 2024 16:55
@deekerno deekerno self-assigned this Mar 19, 2024
Copy link
Contributor

@a5-pickle a5-pickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deekerno can you also fix the propose new auction parameters instruction to use AdminCustodian, too, since the custodian no longer has to be mutable?

@deekerno deekerno force-pushed the solana/fix-proposals branch from 5a8cbbc to e5887ad Compare March 20, 2024 23:04
@deekerno deekerno requested a review from a5-pickle March 20, 2024 23:45
@deekerno deekerno requested a review from a5-pickle March 21, 2024 01:35
Copy link
Contributor

@a5-pickle a5-pickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix reverting with a specific error on owner check in a subsequent PR.

@a5-pickle a5-pickle merged commit f47b5c4 into main Mar 21, 2024
3 checks passed
@a5-pickle a5-pickle deleted the solana/fix-proposals branch March 21, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants