add update and disable endpoints (owner only) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add update router and disable router for engine and router * clean up imports * reorganize modules
gator-boi
reviewed
Mar 13, 2024
a5-pickle
force-pushed
the
update-endpoint
branch
from
012b783 to
792dfbb
Compare
* remove IWormhole.sol and WormholeBytesParsing.sol * add wormhole-solidity-sdk * fix Makefile
a5-pickle
force-pushed
the
update-endpoint
branch
from
47fd525 to
244f1a5
Compare
gator-boi
reviewed
Mar 14, 2024
| @@ -54,6 +57,50 @@ impl common::admin::OwnerAssistant for Custodian { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Accounts)] | |||
| pub struct OwnerCustodian<'info> { | |||
There was a problem hiding this comment.
Got this from our boy @kcsongor
gator-boi
reviewed
Mar 14, 2024
| await expectIxErr(connection, [ix], [ownerAssistant], "Error Code: OwnerOnly"); | ||
| }); | ||
|
|
||
| it("Disable Router Endpoint as Owner", async function () { |
There was a problem hiding this comment.
Might be nice to add a test where we attempt to start an auction for a disabled endpoint.
There was a problem hiding this comment.
Added issue #11 to track this
gator-boi
reviewed
Mar 14, 2024
gator-boi
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the owner or owner assistant could update foreign endpoints.
We now enforce that only the owner can update (and disable) existing endpoints, only allowing the owner assistant to be able to add endpoints.