Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement receive message in solana spoke message executor #191

Merged
merged 18 commits into from
Nov 6, 2024
Merged

Implement receive message in solana spoke message executor #191

merged 18 commits into from
Nov 6, 2024
+1,889 −420

Conversation

zpoken
Copy link
Collaborator

@zpoken zpoken commented Oct 14, 2024

No description provided.

@zpoken zpoken changed the title implement receive_message() WIP: implement receive_message() Oct 14, 2024
@zpoken zpoken force-pushed the solana/feature/spoke-message-executor branch 2 times, most recently from 1712414 to 784c20a Compare October 22, 2024 12:42
@zpoken zpoken force-pushed the solana/feature/spoke-message-executor branch from de54e08 to 4808305 Compare October 29, 2024 15:17
@zpoken zpoken force-pushed the solana/feature/spoke-message-executor branch from 4808305 to d9c038f Compare October 30, 2024 15:46
@zpoken zpoken changed the title WIP: implement receive_message() Implement receive message in solana spoke message executor Oct 31, 2024
@zpoken zpoken marked this pull request as ready for review October 31, 2024 11:03
@nik-suri nik-suri requested review from djb15 and mdulin2 October 31, 2024 16:26
djb15
djb15 reviewed Nov 1, 2024
View reviewed changes
Copy link
Contributor

@djb15 djb15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just reviewed the receive_message function and associated change in context.rs. This PR has a lot of unrelated formatting changes so please point me at any other important changes I haven't look at

zpoken
zpoken commented Nov 1, 2024
View reviewed changes
Copy link
Collaborator Author

@zpoken zpoken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noted all the key changes, everything else is a formatting fix

@zpoken zpoken force-pushed the solana/feature/spoke-message-executor branch from c91e9b3 to 7019633 Compare November 5, 2024 14:35
@zpoken zpoken requested a review from djb15 November 5, 2024 17:11
@zpoken zpoken requested a review from Birua November 6, 2024 12:28
@zpoken zpoken merged commit eea09cc into main Nov 6, 2024
5 checks passed
@nik-suri nik-suri deleted the solana/feature/spoke-message-executor branch November 7, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Birua Birua

@djb15 djb15

@mdulin2 mdulin2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zpoken @Birua @djb15 @Valentine1898