Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented timestamp drift for cast_vote #207

Merged
merged 18 commits into from
Nov 22, 2024
Merged

Implemented timestamp drift for cast_vote #207

merged 18 commits into from
Nov 22, 2024

Conversation

zpoken
Copy link
Collaborator

@zpoken zpoken commented Nov 8, 2024

No description provided.

@zpoken zpoken changed the title WIP: implemented timestamp drift for cast_vote Implemented timestamp drift for cast_vote Nov 12, 2024
@zpoken zpoken marked this pull request as ready for review November 12, 2024 15:06
@zpoken zpoken requested review from Birua and djb15 November 12, 2024 15:06
Birua
Birua previously approved these changes Nov 12, 2024
View reviewed changes
djb15
djb15 reviewed Nov 13, 2024
View reviewed changes
@zpoken
Copy link
Collaborator Author

zpoken commented Nov 14, 2024

We rewrote the part of the code that checks the switch to the second checkpoint account. We removed unnecessary checks. Made it more laconic.

@zpoken zpoken requested a review from djb15 November 14, 2024 17:56
@zpoken zpoken requested a review from Birua November 18, 2024 02:57
Birua
Birua previously approved these changes Nov 18, 2024
View reviewed changes
mat1asm
mat1asm reviewed Nov 19, 2024
View reviewed changes
@zpoken zpoken requested a review from mat1asm November 19, 2024 23:06
@zpoken zpoken requested review from mdulin2 and Birua November 22, 2024 01:30
mdulin2
mdulin2 approved these changes Nov 22, 2024
View reviewed changes
Copy link

@mdulin2 mdulin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a bunch of single comments. Looks good to me now!

@zpoken zpoken merged commit 73200df into main Nov 22, 2024
5 checks passed
@nik-suri nik-suri deleted the feature/timestamp-drift branch November 23, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Birua Birua Birua approved these changes

@mdulin2 mdulin2 mdulin2 approved these changes

@djb15 djb15 Awaiting requested review from djb15

@mat1asm mat1asm Awaiting requested review from mat1asm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zpoken @Birua @djb15 @mdulin2 @mat1asm @Valentine1898