Solana - Low & Informational #230
Merged
+480
−268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djb15
force-pushed
the
solana/fix/low+info
branch
from
a781ee2 to
2cbbf32
Compare
mdulin2
reviewed
Jan 10, 2025
djb15
force-pushed
the
solana/fix/low+info
branch
from
cb552af to
5d3d9e0
Compare
mdulin2
previously approved these changes
Jan 10, 2025
mdulin2
previously approved these changes
Jan 10, 2025
mdulin2
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed 1 commit at a time; each commit corresponds to the numbered issue in the slack thread. See that thread for justification/comments on these changes
In particular could I get some feedback on the changes for
11please. It feels like it could be overkill and the risk of the admin changing the proposal metadata contract is low. Furthermore, if that were to happen an upgrade via multigov governance could add in new functionality to change that, you'd just not be able to vote from the solana spoke on that one proposal. The same applies to the hub message dispatcher, which is currently set once and cannot be changed without an upgrade.