[solana] Scripts to update parameters and vesting tests

[zpoken]

No description provided.

[djb15]

What's the idea behind items 071, 072 and 073? I was expecting to see just deployment steps, but the scripts are creating vesting configs, delegating and claiming vests. Doesn't seem like stuff we want to be doing for the mainnet deployment?

[zpoken]

What's the idea behind items 071, 072 and 073? I was expecting to see just deployment steps, but the scripts are creating vesting configs, delegating and claiming vests. Doesn't seem like stuff we want to be doing for the mainnet deployment?

This was used for deployment and testing in the devnet. We can use them for the mainnet by copying the necessary scripts into a separate folder. Alternatively, we can extend them by adding a network parameter.

[djb15]

Imo anything new going into main at this point should be targeted towards getting ready for mainnet deployment, so I'd personally like to see the deployment steps getting cleaned up for that. Those things I called out aren't necessary for deployment so should be removed from the deployment script altogether. Happy to concede if other reviewers like Max and the Foundation feel otherwise

[zpoken]

Imo anything new going into main at this point should be targeted towards getting ready for mainnet deployment, so I'd personally like to see the deployment steps getting cleaned up for that. Those things I called out aren't necessary for deployment so should be removed from the deployment script altogether. Happy to concede if other reviewers like Max and the Foundation feel otherwise

There are scripts added here that are missing for completeness of documentation for deployment and upgrades.
They are grouped for more order.
We can continue to work with these scripts, rather than the old ones, to prepare a version for deployment to the main network.

[nik-suri]

@djb15 how about putting the vesting scripts in a different folder? We can keep the deploy folder scoped to scripts required for deployment. I think it makes sense to add scripts for creating vesting configs, delegating, and claiming vests in main, but we can keep them separate from the deployment scripts since they are not strictly required.

[djb15]

@djb15 how about putting the vesting scripts in a different folder? We can keep the deploy folder scoped to scripts required for deployment. I think it makes sense to add scripts for creating vesting configs, delegating, and claiming vests in main, but we can keep them separate from the deployment scripts since they are not strictly required.

Yeah I'm ok with that, the zpoken team also suggested on Slack that we have a devnet and mainnet folder to distinguish these scripts. Happy to approve once either/both of those changes are made

[zpoken]

Yeah I'm ok with that, the zpoken team also suggested on Slack that we have a devnet and mainnet folder to distinguish these scripts. Happy to approve once either/both of those changes are made

I will split the deploy into deploy/devnet and deploy/mainnet folders. This will have three different files with constants for local, devnet and mainnet. The last change took a little more time.

[zpoken]

how about putting the vesting scripts in a different folder? We can keep the deploy folder scoped to scripts required for deployment. I think it makes sense to add scripts for creating vesting configs, delegating, and claiming vests in main, but we can keep them separate from the deployment scripts since they are not strictly required.

I separated the scripts for initialize staking program and scripts for vesting into different folders.

[djb15]

Verified that the source code changes are just formatting, and that the deployment folder structure is as discussed. Haven't reviewed the deployment scripts in detail