Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[solana] Deactivate feature for testing to detect stack frame issues #264

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

nvsriram
Copy link
Collaborator

This feature is not enabled on devnet/mainnet. Thus, we deactivate it to ensure stack and heap limits are as expected.

Copy link

@johnsaigle johnsaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I think I gave some bad advice here.

I believe the feature has been re-keyed as of anza-xyz/agave#4058

Tracking this across the new agave/solana repos led me to this wiki: https://github.com/anza-xyz/agave/wiki/Feature-Gate-Tracker-Schedule

So I think the right key to use now is GJVDwRkUPNdk9QaK4VsU4g1N41QNxhy1hevjf8kz45Mq. It would be worth digging into this to confirm.

@nvsriram
Copy link
Collaborator Author

Hey I think I gave some bad advice here.

I believe the feature has been re-keyed as of anza-xyz/agave#4058

Tracking this across the new agave/solana repos led me to this wiki: https://github.com/anza-xyz/agave/wiki/Feature-Gate-Tracker-Schedule

So I think the right key to use now is GJVDwRkUPNdk9QaK4VsU4g1N41QNxhy1hevjf8kz45Mq. It would be worth digging into this to confirm.

I tried changing it to this key but there was no change in local testing - all tests passed. So I don't really have a way to test if this made a difference.

One thing that struck out to me is that the minimum version is v2.1.6 for this re-key. If I understand this correctly, for versions < v2.1.6, we may still need to deactivate the older key.

So something like this should work?

[test.validator]
- deactivate_feature = ["EenyoWx9UMXYKpR8mW5Jmfmy2fRjzUtM7NduYMY8bx33"]
+ deactivate_feature = ["GJVDwRkUPNdk9QaK4VsU4g1N41QNxhy1hevjf8kz45Mq", "EenyoWx9UMXYKpR8mW5Jmfmy2fRjzUtM7NduYMY8bx33"]

@kosedogus
Copy link

kosedogus commented Mar 26, 2025

You can see which features are enabled and disabled via running solana feature status -ul command while running localnet. For 1.18.20 it is enough to deactivate EenyoWx9UMXYKpR8mW5Jmfmy2fRjzUtM7NduYMY8bx33 for deactivating data account mapping.

Copy link

@johnsaigle johnsaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good now. Technically only one key needs to be deactivated but this helps to future-proof the test environment in case of upgrades.

As a note, it looks like the correct flag on e.g. solana 2.2.0 is AjX3A4Nv2rzUuATEUWLP4rrBaBropyUnHxEvFDj1dKbx.

@nvsriram nvsriram merged commit 6bbae08 into main Mar 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants