Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: HubVotePool expanded testing #71

Merged
merged 35 commits into from
Jun 25, 2024
Merged

feat: HubVotePool expanded testing #71

merged 35 commits into from
Jun 25, 2024

Conversation

marcomariscal
Copy link
Collaborator

@marcomariscal marcomariscal commented Jun 10, 2024 •
edited
Loading

Description

Expands the testing for the HubVotePool to handle this issue.

Also includes a check against a zero address/empty bytes in crossChainEVMVote.

@marcomariscal marcomariscal linked an issue Jun 10, 2024 that may be closed by this pull request
Expand testing on HubVotePool #48
Closed
8 tasks
@marcomariscal marcomariscal force-pushed the feat/HubVotePool-expanded-testing branch from 3d6a6c3 to 4222db3 Compare June 10, 2024 20:10
@marcomariscal marcomariscal changed the title feat: hub vote pool expanded testing feat: HubVotePool expanded testing Jun 10, 2024
@marcomariscal marcomariscal force-pushed the feat/HubVotePool-expanded-testing branch from a113e77 to b72fbb4 Compare June 10, 2024 23:15
@marcomariscal marcomariscal marked this pull request as ready for review June 11, 2024 17:46
alexkeating
alexkeating reviewed Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job converting these to fuzz tests I left a few comments.

alexkeating
alexkeating reviewed Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small feedback

@github-actions GitHub Actions
Copy link

Coverage after merging feat/HubVotePool-expanded-testing into main will be

81.91%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   HubGovernor.sol93.55%100%87.50%93.75%138, 91
   HubMessageDispatcher.sol100%100%100%100%
   HubProposalMetadata.sol0%100%0%0%10, 14–15
   HubVotePool.sol100%100%100%100%
   SpokeAirlock.sol100%100%100%100%
   SpokeMessageExecutor.sol95.56%85.71%100%100%43, 61
   SpokeMetadataCollector.sol100%100%100%100%
   SpokeVoteAggregator.sol69.57%50%63.64%77.78%109, 112–113, 65, 74, 82, 88, 88, 88, 90
   WormholeDispatcher.sol29.41%100%33.33%27.27%21–22, 26–27, 31–32, 36–37
src/extensions
   GovernorSettableFixedQuorum.sol100%100%100%100%
src/lib
   SpokeCountingFractional.sol45.45%55.56%37.50%41.38%105–106, 117, 123–124, 151, 151, 151, 153, 155–156, 158, 158, 158, 162, 164–165, 171, 188–190, 42, 49, 58, 98

@alexkeating alexkeating merged commit 2f6bb7f into main Jun 25, 2024
5 checks passed
marcomariscal added a commit that referenced this pull request Dec 9, 2024
@marcomariscal
feat: HubVotePool expanded testing (#71)
ee4c193 
* Expand testing for hub vote pool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkeating alexkeating alexkeating approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand testing on HubVotePool
2 participants
@marcomariscal @alexkeating