-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation #72
Conversation
Also, do we need the window to go in both directions, both before and after the cutoff time? Looks like it just goes in 1 direction right now? |
I don't think it needs to go in both directions. By going in both directions we effectively have a longer window. What is teh reasoning behind having it go in both directions? |
No that's fair I've thought about it some more and I think this is fine, having the window go forwards in time would mean we have a weird period where we can't query successfully. |
b0f01ec
to
9d1af40
Compare
9d1af40
to
efe7df0
Compare
25b3752
to
732d23c
Compare
Coverage after merging feature/add-vote-weight-window into main will be
Coverage Report
|
Description