fix: refactor to separate Endpoint and Manager contracts #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 21, 2024 16:38
djb15
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Generally looks sensible to me!
There are quite a few virtual and override methods around still that no longer have to be so I'd suggest cleaning that up.
The biggest thing imo is getting those integration tests working. Shouldn't actually be a huge lift as the entrypoints have all stayed the same, it's just some setup stuff that you'll have to change
djb15
reviewed
Feb 22, 2024
added 5 commits
February 22, 2024 09:13
RahulMaganti47
changed the title
djb15
reviewed
Feb 22, 2024
RahulMaganti47
force-pushed
the
refactor
branch
from
997e302 to
dbd9bdf
Compare
gator-boi
reviewed
Feb 22, 2024
djb15
reviewed
Feb 22, 2024
djb15
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.