feat: make the consistency level configurable. #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we want to make this configurable when it's going to be an immutable anyway? Is there a world where we don't want finality for the WH endpoint? |
there may be integrators who'd like to choose their own consistency level (even if it is immutable - this allows them to make this choice upfront) |
djb15
reviewed
Feb 22, 2024
| @@ -15,7 +15,7 @@ abstract contract WormholeEndpoint is Endpoint, IWormholeEndpoint, IWormholeRece | |||
|
|
|||
| // TODO -- fix this after some testing | |||
| uint256 public constant GAS_LIMIT = 500000; | |||
| uint8 public constant CONSISTENCY_LEVEL = 1; | |||
| uint8 public immutable consistencyLevel; | |||
There was a problem hiding this comment.
Can we add a docstring above this then to specify common consistency levels that integrators might want to use and why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154.