Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate event emissions #223

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix: remove duplicate event emissions #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions evm/src/NttManager/TransceiverRegistry.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ abstract contract TransceiverRegistry {
error NonRegisteredTransceiver(address transceiver);
error TransceiverAlreadyEnabled(address transceiver);

event TransceiverAdded(address transceiver);
event TransceiverRemoved(address transceiver);

modifier onlyTransceiver() {
if (!_getTransceiverInfosStorage()[msg.sender].enabled) {
revert CallerNotTransceiver(msg.sender);
Expand Down Expand Up @@ -150,8 +147,6 @@ abstract contract TransceiverRegistry {
}
_enabledTransceiverBitmap.bitmap = updatedEnabledTransceiverBitmap;

emit TransceiverAdded(transceiver);

_checkTransceiversInvariants();

return transceiverInfos[transceiver].index;
Expand Down Expand Up @@ -196,8 +191,6 @@ abstract contract TransceiverRegistry {
}
assert(removed);

emit TransceiverRemoved(transceiver);

_checkTransceiversInvariants();
// we call the invariant check on the transceiver here as well, since
// the above check only iterates through the enabled transceivers.
Expand Down
Loading