Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm: natspec changes and additions #249

Merged
merged 9 commits into from
Mar 6, 2024
Merged

evm: natspec changes and additions #249

merged 9 commits into from
Mar 6, 2024

Conversation

RahulMaganti47
Copy link
Contributor

No description provided.

gator-boi
gator-boi previously approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@gator-boi gator-boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. A little nit picky, but it would be nice if we followed the same indentation rules for multi-line comments. Whether that's indenting (or not) it should be uniform.

@RahulMaganti47
Copy link
Contributor Author

Lgtm. A little nit picky, but it would be nice if we followed the same indentation rules for multi-line comments. Whether that's indenting (or not) it should be uniform.

yea i prefer the indenting. if we're agreed on that, i can modify the other natspec comments as well

@RahulMaganti47 RahulMaganti47 requested a review from djb15 March 4, 2024 16:46
@RahulMaganti47 RahulMaganti47 marked this pull request as ready for review March 4, 2024 16:46
djb15
djb15 reviewed Mar 4, 2024
View reviewed changes
@RahulMaganti47 RahulMaganti47 force-pushed the additional-natspec branch 4 times, most recently from 5a10da2 to 8b7cf91 Compare March 4, 2024 19:14
djb15
djb15 previously approved these changes Mar 4, 2024
View reviewed changes
@RahulMaganti47 RahulMaganti47 force-pushed the additional-natspec branch 2 times, most recently from 78dd086 to 5564175 Compare March 5, 2024 15:52
@gator-boi gator-boi self-requested a review March 5, 2024 20:13
gator-boi
gator-boi previously approved these changes Mar 5, 2024
View reviewed changes
@RahulMaganti47 RahulMaganti47 requested a review from djb15 March 5, 2024 20:39
djb15
djb15 previously approved these changes Mar 5, 2024
View reviewed changes
@RahulMaganti47 RahulMaganti47 dismissed stale reviews from djb15 and gator-boi via 3e565bd March 6, 2024 15:09
@RahulMaganti47 RahulMaganti47 force-pushed the additional-natspec branch 4 times, most recently from 07043db to bbf02bd Compare March 6, 2024 15:16
@RahulMaganti47 RahulMaganti47 merged commit 1570241 into main Mar 6, 2024
4 checks passed
@RahulMaganti47 RahulMaganti47 deleted the additional-natspec branch March 6, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcsongor kcsongor kcsongor approved these changes

@djb15 djb15 djb15 approved these changes

@gator-boi gator-boi gator-boi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RahulMaganti47 @kcsongor @djb15 @gator-boi