-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment scripts #288
Deployment scripts #288
Conversation
9ecdc79
to
dad0c1e
Compare
e03ad78
to
d8a0568
Compare
4086b08
to
80f7ce5
Compare
8b8303e
to
b482d31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with comments
@@ -28,27 +28,27 @@ | |||
"peerQuotes": { | |||
"Sepolia": { | |||
"maxGasDropoffEth": "0", | |||
"basePriceUsd": "500000", | |||
"nativePriceUsd": "3500000000", | |||
"basePriceUsd": "1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be 0.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually commited the wrong file, I wanted to commit mainnet
"basePriceUsd": "500000", | ||
"nativePriceUsd": "3500000000", | ||
"basePriceUsd": "1", | ||
"nativePriceUsd": "3865", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is okay you updated here, but the assistant should take care of this value since sepolia will not be disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved now for Mainnet. Let a comment about this value
"gasCost": 500000,
ef45867
to
9c4a11c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GasPrice could be updated as well to 29, but since the assistant should take care of that is fine
Adds EVM deployment scripts to:
To-do list: