SDK: Solana TS deduplication #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnjamin
changed the title
barnjamin
force-pushed
the
sdk/solana-dedupe
branch
from
3151052 to
b30969b
Compare
barnjamin
force-pushed
the
sdk/solana-dedupe
branch
from
b30969b to
f0f5549
Compare
barnjamin
force-pushed
the
sdk/solana-dedupe
branch
from
5980a3c to
c3b3c7b
Compare
kev1n-peters
approved these changes
May 6, 2024
kcsongor
reviewed
May 8, 2024
kcsongor
reviewed
May 8, 2024
kcsongor
reviewed
May 8, 2024
kcsongor
approved these changes
May 8, 2024
barnjamin
force-pushed
the
sdk/solana-dedupe
branch
from
97828c7 to
994300d
Compare
barnjamin
added a commit
that referenced
this pull request
Jun 6, 2024
kcsongor
pushed a commit
to wormholelabs-xyz/native-token-transfers
that referenced
this pull request
Jun 7, 2024
barnjamin
added a commit
that referenced
this pull request
Jun 7, 2024
barnjamin
added a commit
that referenced
this pull request
Jun 7, 2024
barnjamin
added a commit
that referenced
this pull request
Jun 13, 2024
barnjamin
added a commit
that referenced
this pull request
Jun 14, 2024
* SDK: Migrate Solana TS code to Solana dir (#433) * bump to stable version of sdk * Move generated IDL to ts directory (#437) * Move generated IDL to ts directory * update github action with new idl path * Update to use the ts exported IDL instead of the json * rebase and regenerate bindings * remove generics from generated idl * add generic stripper to makefile, use ts IDL for binding loader * update bindings to work for both versions (#439) * remove dupe quoter implementation, pass args to createRequestRelayInstruction * Partial CR fixes * Update makefile with suggestions from CR * skip anchor build on test * SDK: Solana TS deduplication (#442) * set peer dep for ntt route * update version * prev commit for tilt to test * restore tiltfile git checkout to main * Add 1.1.0 evm bindings (#457)
kcsongor
pushed a commit
to wormholelabs-xyz/native-token-transfers
that referenced
this pull request
Jun 18, 2024
bruce-riley
pushed a commit
to wormholelabs-xyz/native-token-transfers
that referenced
this pull request
Sep 12, 2024
* SDK: Migrate Solana TS code to Solana dir (wormhole-foundation#433) * bump to stable version of sdk * Move generated IDL to ts directory (wormhole-foundation#437) * Move generated IDL to ts directory * update github action with new idl path * Update to use the ts exported IDL instead of the json * rebase and regenerate bindings * remove generics from generated idl * add generic stripper to makefile, use ts IDL for binding loader * update bindings to work for both versions (wormhole-foundation#439) * remove dupe quoter implementation, pass args to createRequestRelayInstruction * Partial CR fixes * Update makefile with suggestions from CR * skip anchor build on test * SDK: Solana TS deduplication (wormhole-foundation#442) * set peer dep for ntt route * update version * prev commit for tilt to test * restore tiltfile git checkout to main * Add 1.1.0 evm bindings (wormhole-foundation#457)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert NTT class to namespace and treat it as a library of utility functions to get instructions or transactions created
Delete duplicated logic for creating instructions or transactions