Typescript SDK changes and bug fixes needed for Connect #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kev1n-peters
commented
Jul 11, 2024
kev1n-peters
commented
- Added a WormholeTransferStandardRelayer payload type needed to parse the VAA for an automatic transfer between EVM chains
- EVM: getIsExecuted should check if the transfer is inbound queued to determine if the transfer is completed
- Solana: getIsExecuted should check if the inboxItem is released
- Solana: getIsApproved should not swallow exception
- Solana: getInboundQueuedTransfer should return null if the transfer is not queued
- Bumped SDK dependencies needed for Connect
|
Should probably publish SDK |
kev1n-peters
force-pushed
the
connect-ntt-fixes
branch
5 times, most recently
from
43f4ac6 to
1446173
Compare
- Added a WormholeTransferStandardRelayer payload type needed to parse the VAA for an automatic transfer between EVM chains - EVM: getIsExecuted should check if the transfer is inbound queued to determine if the transfer is completed - Solana: getIsExecuted should check if the inboxItem is released - Solana: getIsApproved should not swallow exception - Solana: getInboundQueuedTransfer should return null if the transfer is not queued - Bumped SDK dependencies needed for Connect
kev1n-peters
force-pushed
the
connect-ntt-fixes
branch
from
60c3ed8 to
e181ba7
Compare
barnjamin
reviewed
Jul 17, 2024
barnjamin
reviewed
Jul 17, 2024
barnjamin
reviewed
Jul 17, 2024
barnjamin
previously approved these changes
Jul 17, 2024
barnjamin
previously approved these changes
Jul 17, 2024
barnjamin
approved these changes
Jul 17, 2024
artursapek
approved these changes
Jul 18, 2024
bruce-riley
pushed a commit
to wormholelabs-xyz/native-token-transfers
that referenced
this pull request
Sep 12, 2024
…ndation#474) * Typescript SDK changes and bug fixes needed for Connect - Added a WormholeTransferStandardRelayer payload type needed to parse the VAA for an automatic transfer between EVM chains - EVM: getIsExecuted should check if the transfer is inbound queued to determine if the transfer is completed - Solana: getIsExecuted should check if the inboxItem is released - Solana: getIsApproved should not swallow exception - Solana: getInboundQueuedTransfer should return null if the transfer is not queued - Bumped SDK dependencies needed for Connect * Added NTT quote warnings, semver ABI support, fixed queued transfer issues * Added getIsTransferInboundQueued method * bumped sdk deps to ^0.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.