Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: query token decimals outside of forge script #490

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Conversation

kcsongor
Copy link
Contributor

This works around and edge case when the token contract is compiled against a different EVM version than what the forge script is running in (london currently).

@kcsongor kcsongor requested a review from evgeniko July 31, 2024 11:17
Copy link
Collaborator

@evgeniko evgeniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kcsongor kcsongor force-pushed the cli-token-decimals branch 2 times, most recently from 6766590 to 7f17526 Compare July 31, 2024 12:13
kcsongor and others added 5 commits July 31, 2024 13:13
This works around and edge case when the token contract is compiled
against a different EVM version than what the forge script is running
in (london currently).
@kcsongor kcsongor merged commit 3e49e03 into cli Jul 31, 2024
8 checks passed
@kcsongor kcsongor deleted the cli-token-decimals branch July 31, 2024 15:16
kcsongor added a commit that referenced this pull request Aug 29, 2024
* cli: query token decimals outside of forge script

This works around and edge case when the token contract is compiled
against a different EVM version than what the forge script is running
in (london currently).

* cli: mock token decimals in the failure case

* cli: add option to retry deployment without simulation (evm)

---------

Co-authored-by: evgenidefi <evgeni.kozyr1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants