Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana: Add anchor linting #507

Merged
merged 5 commits into from
Sep 3, 2024
Merged

solana: Add anchor linting #507

merged 5 commits into from
Sep 3, 2024

Conversation

nvsriram
Copy link
Collaborator

@nvsriram nvsriram commented Sep 1, 2024

This PR is based on #330.

johnsaigle and others added 5 commits September 1, 2024 00:43
Add a bash script to manually run anchor linting commands as it does not
occur automatically in anchor-cli 0.29.0
Add Makefile targets that point to the new script
Add CI step to run the new make command
@nvsriram nvsriram marked this pull request as ready for review September 3, 2024 16:54
@nvsriram
Copy link
Collaborator Author

nvsriram commented Sep 3, 2024

Usage of UncheckedAccount for the token_authority in initialize leads to stack access violation so leaving it as AccountInfo. Could refactor code using Box<_> to reduce stack size.

@nvsriram nvsriram merged commit 5faa2ff into main Sep 3, 2024
9 checks passed
@nvsriram nvsriram deleted the solana/anchor-lints branch September 3, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants