Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: Fix minor issues from PR #4 #579

Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
evm: Fix minor issues from PR#4
bruce-riley committed Dec 23, 2024
commit f7c7f72b3505826dce3e340b51a8dee8f0f9b44d
1 change: 1 addition & 0 deletions evm/src/NttManager/ManagerBase.sol
Original file line number Diff line number Diff line change
@@ -354,6 +354,7 @@ abstract contract ManagerBase is
assert(this.mode() == mode);
assert(this.chainId() == chainId);
assert(this.endpoint() == endpoint);
assert(this.executor() == executor);
}

function _checkThresholdInvariants() internal view {
2 changes: 2 additions & 0 deletions evm/src/NttManager/NttManager.sol
Original file line number Diff line number Diff line change
@@ -662,6 +662,8 @@ contract NttManager is INttManager, RateLimiter, ManagerBase {

uint128 gasLimit = peerData.gasLimit;
if (gasLimit == 0) {
// The gas limit can only be zero when a contract has been migrated from an older version,
// where the gasLimit was not defined in the manager peer struct and was not set during the upgrade.
revert InvalidGasLimitZero(args.recipientChain);
}