Display the USD equivalent of all fees regardless of designated currency #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wormhole-connect ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wormhole-connect-builder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wormhole-connect-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sebastianscatularo
requested changes
Feb 7, 2024
|
I would definitely knock that down to two decimal places. showing six decimals on USD seems pretty excessive. |
sebastianscatularo
previously approved these changes
Feb 8, 2024
|
@yuli-ferna one other comment: for formatting $ values in javascript in general I highly recommend I'd expect some people are moving 6+ figure USD values with Connect. these numbers can get hard to read if you don't have commas. |
|
@artursapek Thanks for the advice, I upload the changes |
artursapek
reviewed
Feb 8, 2024
sebastianscatularo
previously approved these changes
Feb 9, 2024
sebastianscatularo
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1436
Result:
