Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: unset defaults if they're invalid #1848

Closed
wants to merge 1 commit into from

Conversation

artursapek
Copy link
Collaborator

An integrator pointed out that Connect errors out when a chain is misconfigured in bridgeDefaults. This fixes that by removing that config setting in validateDefaults.

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for wormhole-connect-builder ready!

Name Link
🔨 Latest commit 30dee16
🔍 Latest deploy log https://app.netlify.com/sites/wormhole-connect-builder/deploys/66047822f2fdf400085dcdc8
😎 Deploy Preview https://deploy-preview-1848--wormhole-connect-builder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for wormhole-connect ready!

Name Link
🔨 Latest commit 30dee16
🔍 Latest deploy log https://app.netlify.com/sites/wormhole-connect/deploys/66047822a4f0de00089d1421
😎 Deploy Preview https://deploy-preview-1848--wormhole-connect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for wormhole-connect-mainnet ready!

Name Link
🔨 Latest commit 30dee16
🔍 Latest deploy log https://app.netlify.com/sites/wormhole-connect-mainnet/deploys/6604782239f2740008fe7b0b
😎 Deploy Preview https://deploy-preview-1848--wormhole-connect-mainnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@artursapek artursapek changed the title Unset defaults if they're invalid Bug fix: unset defaults if they're invalid Mar 27, 2024
@artursapek artursapek marked this pull request as ready for review March 27, 2024 20:56
@artursapek artursapek requested a review from kev1n-peters March 27, 2024 20:56
@aadam-10 aadam-10 linked an issue Apr 5, 2024 that may be closed by this pull request
@artursapek artursapek closed this May 21, 2024
@artursapek artursapek reopened this May 21, 2024
@artursapek artursapek closed this May 21, 2024
@aadam-10 aadam-10 deleted the improve-chain-validation branch March 12, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug fix: unset defaults if they're invalid
2 participants