Remove "Review transaction" view #3164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wormhole-connect ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wormhole-connect-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
emreboga
commented
Jan 9, 2025
emreboga
commented
Jan 9, 2025
emreboga
force-pushed
the
emre/remove-review-tx-view-4
branch
2 times, most recently
from
525af70 to
5ef14cf
Compare
emreboga
force-pushed
the
emre/remove-review-tx-view-4
branch
4 times, most recently
from
77287c1 to
62351c5
Compare
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
This reverts commit f4aff98.
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
emreboga
force-pushed
the
emre/remove-review-tx-view-4
branch
from
62351c5 to
a68af7b
Compare
artursapek
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove the "Review Transaction" view/step and allow user to confirm a transaction from the main view. One important change here is moving the gas slider inside the route card for those that has gas top-up enabled.