Fix circular progress animation styles #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
✅ Deploy Preview for wormhole-connect ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wormhole-connect-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
emreboga
commented
Feb 20, 2025
emreboga
merged commit 315cbf5
into
wormhole-foundation:development
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been an issue the way we were animating the circular progress in one smooth move after React 19 upgrade. This was because an added animation was not triggered all the time after re-render of the component. It was very inconsistent.
The fix here is remove the old logic and do not depend on the animation to simulate the progress, but use the percent value and add an animation to make the steps in that progress upgrade a bit smoother.
https://www.loom.com/share/1a8417d6021041899bc0564d94abe105?sid=6277fbd0-592b-4deb-87d0-23989896af9f