Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

historical uptime: missing signature tracking #199

Merged
merged 1 commit into from
Feb 7, 2024
Merged

historical uptime: missing signature tracking #199

merged 1 commit into from
Feb 7, 2024

Conversation

bingyuyap
Copy link
Contributor

@bingyuyap bingyuyap commented Feb 6, 2024 •
edited
Loading

this pr does the below:

  • indexes and deduplicates observations
  • checks for expiry status of observations
  • computes missing observation count for each guardian and each chain
  • pushes missing observation count to prometheus

example dashboard with missing observations and height sync status:
image

to do:

  • database cleanup

@bingyuyap bingyuyap changed the title Bing/historical uptime missing signature historical uptime: missing signature tracking Feb 6, 2024
@bingyuyap bingyuyap requested review from panoel and evan-gray February 6, 2024 08:03
@bingyuyap bingyuyap marked this pull request as ready for review February 6, 2024 08:03
@bingyuyap bingyuyap force-pushed the bing/historical-uptime-missing-signature branch from 9cd31df to 0e15c20 Compare February 6, 2024 08:05
bruce-riley
bruce-riley previously approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@bruce-riley bruce-riley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few minor comments.

@bingyuyap bingyuyap force-pushed the bing/historical-uptime-missing-signature branch from 0e15c20 to 82fe4a8 Compare February 7, 2024 01:48
@bingyuyap bingyuyap requested a review from bruce-riley February 7, 2024 01:50
@bingyuyap
historical_uptime: track missing observations by guardians
099ceb9 
Signed-off-by: bingyuyap <bingyu.yap.21@gmail.com>
@bingyuyap bingyuyap force-pushed the bing/historical-uptime-missing-signature branch from 82fe4a8 to 099ceb9 Compare February 7, 2024 06:50
@bingyuyap bingyuyap merged commit b2f23e2 into main Feb 7, 2024
@bingyuyap bingyuyap deleted the bing/historical-uptime-missing-signature branch February 7, 2024 19:37
@bingyuyap bingyuyap mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panoel panoel panoel approved these changes

@bruce-riley bruce-riley bruce-riley approved these changes

@evan-gray evan-gray Awaiting requested review from evan-gray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bingyuyap @panoel @bruce-riley