Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ft merge #400

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Change ft merge #400

merged 4 commits into from
Feb 19, 2025

Conversation

panoel
Copy link
Contributor

@panoel panoel commented Jan 31, 2025

This PR:

  • updates how data is merged into the pg db for EVM.
  • updates the imported code from liquidity layer.
  • uses a different approach to look for fast transfers on EVM.
  • picks up a newer version of the example-liquidity-layer repo in the submodule.

@panoel panoel requested a review from evan-gray January 31, 2025 20:27
@evan-gray
Copy link
Contributor

confirmed I was able to reproduce the .tgz artifacts with the following commands

cd watcher/sdk/example-liquidity-layer/evm 
make
cd -
cd watcher/sdk/example-liquidity-layer 
npm ci
npm run build
npm run pack
cp *.tgz .. 
cd -

would be good to have the makefile do this and best to have CI confirm it a la https://github.com/wormhole-foundation/wormhole/blob/main/.github/workflows/build.yml#L262-L263

evan-gray
evan-gray previously approved these changes Feb 7, 2025
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just gave a high-level pass. could be a couple things worth cleaning up, but could be merged as is given that it's independent.

@panoel panoel merged commit 8e75093 into main Feb 19, 2025
4 checks passed
@panoel panoel deleted the change_ft_merge branch February 19, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants