Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watcher: refactor #407

Merged
merged 3 commits into from
Feb 28, 2025
Merged

watcher: refactor #407

merged 3 commits into from
Feb 28, 2025

Conversation

panoel
Copy link
Contributor

@panoel panoel commented Feb 21, 2025

This PR refactors the watchers in order to make the class hierarchy clearer and code reuse better.

@panoel panoel mentioned this pull request Feb 21, 2025
Closed
evan-gray
evan-gray requested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question and opportunity for a little more cleanup :)

evan-gray
evan-gray previously approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming all of those EVM chains support finalized this seems like it would work, but would be best to confirm (unless the code did this before, but it seems like it defaulted to latest

evan-gray
evan-gray previously approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@evan-gray evan-gray left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that this changes the default to use the finalized block tag, and I'm not confident that every chain listed in utils.ts supports that. This should be tested carefully before or when deploying.

@panoel panoel requested a review from evan-gray February 27, 2025 21:45
@panoel panoel merged commit 440b853 into main Feb 28, 2025
3 of 4 checks passed
@panoel panoel deleted the watcher-refactor branch February 28, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-gray evan-gray evan-gray approved these changes

@bruce-riley bruce-riley Awaiting requested review from bruce-riley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panoel @evan-gray