cloud_functions: getQuorumHeight #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panoel
reviewed
Mar 14, 2025
panoel
reviewed
Mar 14, 2025
panoel
reviewed
Mar 14, 2025
panoel
previously approved these changes
Mar 14, 2025
evan-gray
force-pushed
the
get-quorum-height
branch
from
aad378f to
26f6be4
Compare
panoel
approved these changes
Mar 17, 2025
am-os
reviewed
Mar 17, 2025
| latestHeights.sort((a, b) => (a > b ? -1 : a < b ? 1 : 0)); | ||
| safeHeights.sort((a, b) => (a > b ? -1 : a < b ? 1 : 0)); | ||
| finalizedHeights.sort((a, b) => (a > b ? -1 : a < b ? 1 : 0)); | ||
| const quorumIdx = getQuorumCount(latestHeights.length) - 1; |
There was a problem hiding this comment.
Is this polling the 13th highest height? Should we remove the - 1 at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new function gets the quorum height for latest, safe, and finalized per the guardian heartbeats cached in firestore.
Deployed to testnet and mainnet