Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Martinh/ntt sol reshape #257
Martinh/ntt sol reshape #257
Changes from 13 commits
7631d34
51794b6
fb34098
0670528
f126cac
3a1d030
37df8b6
059caa3
014bcf9
1872c5f
2ff51ed
55f189a
a7e1ec1
685af45
a14c276
66a8c0a
0cb5b60
2177c8f
f1803ee
6108b5a
f64967b
ce9d771
494848a
9811013
c8e1cb8
16c6bb5
8db7104
80cce26
45e2b32
83149a7
913a206
20021d3
6f2ecb5
bde163c
4ed594f
e8ba1f5
06cdef4
9246988
9651fa8
7c5fb4a
ece6fc1
601ac88
b9e115f
d176482
67b0c9f
b881fa4
4ff0324
fb9423c
77d9610
70ec179
47889ba
97360f3
f7492e9
62c414a
8e0dbe2
a81ea77
0735eef
6a05ebe
5bbec0a
540dea5
d772723
5155a27
2eb0c4c
845aa56
e8e7077
ae5a2fc
f2f5196
cf37098
161a59a
bfc2de0
25b2ae2
b0d3035
ff63096
12a4af9
69df41a
d61e580
65dc6e8
03f17b7
928559b
3a66003
d827a01
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this specific to an EVM deployment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, values must be set using 18 decimals for EVM chains, while Solana uses 9 decimals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you think it for sure belongs on the Solana deployment page? Or is this something that should only matter for EVM deployments and should only be on the EVM deployment page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's necessary to have it here. Devs will mostly use NTT between EVM and Solana, so they should definitely know how to set the decimals for the EVM chain so their transactions go through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do they have to deploy their token on EVM too then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like where are these configurations added if this is the Solana deployment?