Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up contract controlled transfers #298

Merged
merged 9 commits into from
Mar 20, 2025

Conversation

eshaben
Copy link
Collaborator

@eshaben eshaben commented Mar 17, 2025

Description

Instead of contract controlled transfers, this switches to token transfers with messages. Since they're all links, I capitalized the link text cause it pretty much matches the header text (minus some pluralization)

Checklist

  • Required - I have added a label to this PR 🏷️

eshaben and others added 5 commits February 19, 2025 00:36
* add settlement to learn section

* add settlement to buil section

* fix links

* liquidity layer code snippets

* solver snippets

* llms

---------

Co-authored-by: Ilaria Enache <ilaria@Host-009.homenet.telecomitalia.it>
* adds connect index page to new IA

* tweaks admonition usage on /docs/build/transfers/connect/overview/

* moves timeline into snippet, left aligned

* feedback per review

* llms

* edits per feedback

* improve intro

* edits per feedback

* applies review feedback

* Apply suggestions from code review

Co-authored-by: Erin Shaben <eshaben@icloud.com>

---------

Co-authored-by: Erin Shaben <eshaben@icloud.com>
* adds token bridge build page in the new ai and fixes links

* Update build/transfers/token-bridge.md

Co-authored-by: Lucas Malizia <131050418+0xlukem@users.noreply.github.com>

* Update build/transfers/token-bridge.md

Co-authored-by: Lucas Malizia <131050418+0xlukem@users.noreply.github.com>

---------

Co-authored-by: Ilaria Enache <ilaria@Host-009.homenet.telecomitalia.it>
Co-authored-by: Lucas Malizia <131050418+0xlukem@users.noreply.github.com>
@eshaben eshaben requested a review from dawnkelly09 as a code owner March 17, 2025 19:40
@eshaben eshaben requested a review from ilariae March 17, 2025 19:40
@eshaben eshaben added A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.) B0 - Needs Review Pull request is ready for review C0 - Low Low priority task labels Mar 17, 2025
@eshaben eshaben mentioned this pull request Mar 17, 2025
ilariae
ilariae previously approved these changes Mar 17, 2025
@eshaben eshaben changed the base branch from new-product-ia to main March 19, 2025 18:35
@eshaben eshaben dismissed ilariae’s stale review March 19, 2025 18:35

The base branch was changed.

@eshaben eshaben changed the base branch from main to new-product-ia March 19, 2025 18:43
@eshaben eshaben changed the base branch from new-product-ia to main March 19, 2025 18:45
@eshaben eshaben requested review from ilariae and martin0995 March 20, 2025 04:37
Copy link
Collaborator

@ilariae ilariae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Mar 20, 2025
@martin0995 martin0995 merged commit 06c149c into main Mar 20, 2025
2 checks passed
@martin0995 martin0995 deleted the eshaben/contract-controlled-transfers branch March 20, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.) B1 - Ready to Merge Pull request is ready to be merged C0 - Low Low priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants