-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up contract controlled transfers #298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add settlement to learn section * add settlement to buil section * fix links * liquidity layer code snippets * solver snippets * llms --------- Co-authored-by: Ilaria Enache <ilaria@Host-009.homenet.telecomitalia.it>
* adds connect index page to new IA * tweaks admonition usage on /docs/build/transfers/connect/overview/ * moves timeline into snippet, left aligned * feedback per review * llms * edits per feedback * improve intro * edits per feedback * applies review feedback * Apply suggestions from code review Co-authored-by: Erin Shaben <eshaben@icloud.com> --------- Co-authored-by: Erin Shaben <eshaben@icloud.com>
* adds token bridge build page in the new ai and fixes links * Update build/transfers/token-bridge.md Co-authored-by: Lucas Malizia <131050418+0xlukem@users.noreply.github.com> * Update build/transfers/token-bridge.md Co-authored-by: Lucas Malizia <131050418+0xlukem@users.noreply.github.com> --------- Co-authored-by: Ilaria Enache <ilaria@Host-009.homenet.telecomitalia.it> Co-authored-by: Lucas Malizia <131050418+0xlukem@users.noreply.github.com>
Open
ilariae
previously approved these changes
Mar 17, 2025
ilariae
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
dawnkelly09
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This was referenced Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A3 - Quick Fixes
Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.)
B1 - Ready to Merge
Pull request is ready to be merged
C0 - Low
Low priority task
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of contract controlled transfers, this switches to token transfers with messages. Since they're all links, I capitalized the link text cause it pretty much matches the header text (minus some pluralization)
Checklist