Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ilariae/architecture #3

Merged
merged 16 commits into from
Jul 31, 2024
Merged

Ilariae/architecture #3

merged 16 commits into from
Jul 31, 2024

Conversation

ilariae
Copy link
Collaborator

@ilariae ilariae commented Jul 29, 2024

Description

Added Architecture overview page

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@ilariae ilariae added the A0 - New Content Pull request contains new content pages label Jul 29, 2024
@ilariae ilariae requested review from eshaben and dawnkelly09 July 29, 2024 11:07
dawnkelly09
dawnkelly09 requested changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small things which I left suggestions for. It looks like there are a few spots where links need inserted but that content isn't there to link just but I assume we are aware.

ilariae and others added 2 commits July 29, 2024 18:26
@ilariae @dawnkelly09
Update learn/.pages
dafd798 
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
@ilariae @dawnkelly09
Update learn/.pages
ebb4fd3 
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
@ilariae
Copy link
Collaborator Author

ilariae commented Jul 29, 2024

A couple small things which I left suggestions for. It looks like there are a few spots where links need inserted but that content isn't there to link just but I assume we are aware.

yes I'm aware I left a comment at the top for it, I will come back to it and add the missing links once the pages for them are created

@ilariae ilariae requested a review from dawnkelly09 July 29, 2024 16:37
dawnkelly09
dawnkelly09 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for the early version of this page. :-)

eshaben
eshaben reviewed Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeet! Most of my comments are around capitalization

eshaben
eshaben reviewed Jul 30, 2024
View reviewed changes
Ilaria Enache and others added 9 commits July 31, 2024 10:42
fetch intro and security pages from main
9a4b595
@ilariae @eshaben
Update learn/architecture.md
94b01a5 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/architecture.md
a332043 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/architecture.md
ce1c088 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/architecture.md
7c8a718 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/architecture.md
aa759b9 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
linked architecture in introduction
d4e0231
updated image naming
10d144a
@ilariae @eshaben
Update learn/architecture.md
2aa22da 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
eshaben
eshaben approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben eshaben merged commit 1212370 into main Jul 31, 2024
1 check passed
@eshaben eshaben deleted the ilariae/architecture branch July 31, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawnkelly09 dawnkelly09 dawnkelly09 approved these changes

@eshaben eshaben eshaben approved these changes

Assignees
No one assigned
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilariae @eshaben @dawnkelly09