Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Martinh/sol ntt feedback #323

Merged
merged 6 commits into from
Mar 25, 2025
Merged

Martinh/sol ntt feedback #323

merged 6 commits into from
Mar 25, 2025

Conversation

martin0995
Copy link
Collaborator

Description

Based on feedback, this PR moves the "Create and Mint Tokens" section to an expandable.

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@martin0995 martin0995 added A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B0 - Needs Review Pull request is ready for review labels Mar 24, 2025
eshaben
eshaben reviewed Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martin0995 !

@martin0995 martin0995 requested a review from eshaben March 24, 2025 18:39
eshaben
eshaben approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Mar 24, 2025
@martin0995 martin0995 merged commit 189aa13 into main Mar 25, 2025
2 checks passed
@martin0995 martin0995 deleted the martinh/sol-ntt-feedback branch March 25, 2025 16:18
This was referenced Mar 25, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshaben eshaben eshaben approved these changes

@dawnkelly09 dawnkelly09 Awaiting requested review from dawnkelly09 dawnkelly09 is a code owner

Assignees
No one assigned
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to Merge Pull request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin0995 @eshaben