Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ilariae/vaas #7
Ilariae/vaas #7
Changes from 30 commits
790af81
71b8b3c
6e2ed3d
214dd61
f08e7cb
bb4358f
fc97a34
be237b0
89337bb
7392a27
897c7c7
beaf13c
f66a36c
93e8d4e
20adb2b
aa75d31
a7ca487
b0103e2
90b6cdf
b45a68c
02c8e28
1e4aa6d
f26c67d
aaca738
55627f0
1802131
d2aa374
5f5dcda
69489b1
1eed836
7ff734b
024319c
4491bf0
213cce5
41aa8a2
44c9185
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The body contains relevant information for consumers"
Is there some way to reword this? Who are the consumers? Are we talking about devs, end users, etc? Otherwise, I think "The body is returned form a call.." is less confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to run grammarly on this . There should probably be a comma before
which the developer
and it might provide other recsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consumer should refer to any entity that receives a VAA, could be a contract, a dev or whatever
afaik the only way the body is returned is through parseAndVerifyVAA but there's a bit of confusion around who calls this method
I actually mentioned this unclarity in my painpoints doc and got this answer:
"Andreas: Regarding the "who calls parseAndVerifyVAA)?
The architecture diagram "shows" (more like "suggests") that the entry point on the target chain is the target contract which then calls the core contract to verify. But yeah, this needs a lot more clarity, and it's not true when you use other protocols such as the token bridge, where you only talk to the token bridge and the token bridge in turn interacts with the core contract."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reworded this:
The body contains relevant information for entities, such as contracts, or other systems, that process or utilize VAAs. When a function like
parseAndVerifyVAA
is called, the body is returned, allowing verification of theemitterAddress
to determine if the VAA originated from a trusted contract.