Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ilariae/core contracts #8

Merged
merged 64 commits into from
Aug 12, 2024
Merged

Ilariae/core contracts #8

merged 64 commits into from
Aug 12, 2024

Conversation

ilariae
Copy link
Collaborator

@ilariae ilariae commented Aug 1, 2024

Description

Core contracts page, token and nft bridge page and partial content for the overview page

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@ilariae ilariae added the A0 - New Content Pull request contains new content pages label Aug 1, 2024
@ilariae ilariae requested review from eshaben and dawnkelly09 August 1, 2024 10:57
eshaben
eshaben reviewed Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some initial comments

Ilaria Enache and others added 7 commits August 6, 2024 11:27
dawnkelly09
dawnkelly09 requested changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of internal links that don't route anywhere yet. Just need to make sure we are going back and making those connections as the destinations are added.

ilariae and others added 4 commits August 8, 2024 10:46
@ilariae @dawnkelly09
Update learn/messaging/core-contracts.md
1671845 
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
@ilariae @dawnkelly09
Update learn/messaging/core-contracts.md
b6353a2 
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
@ilariae @dawnkelly09
Update learn/messaging/core-contracts.md
de63190 
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
@ilariae @dawnkelly09
Update learn/messaging/core-contracts.md
39d3492 
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
ilariae and others added 5 commits August 8, 2024 11:00
@ilariae @dawnkelly09
Update learn/messaging/core-contracts.md
14583e8 
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
@ilariae @dawnkelly09
Update learn/messaging/core-contracts.md
dce18ff 
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
@ilariae @dawnkelly09
Update learn/messaging/overview.md
d2832a9 
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Merge branch 'ilariae/VAAs' of https://github.com/wormhole-foundation…
06b8fe2 
…/wormhole-docs into ilariae/core-contracts
Merge branch 'main' of https://github.com/wormhole-foundation/wormhol…
73da350 
…e-docs into ilariae/core-contracts
eshaben
eshaben reviewed Aug 9, 2024
View reviewed changes
ilariae and others added 14 commits August 9, 2024 10:40
@ilariae @eshaben
Update learn/messaging/core-contracts.md
73e8cba 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/messaging/core-contracts.md
a6ae993 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/messaging/core-contracts.md
6d14294 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/messaging/core-contracts.md
477a7f8 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/messaging/core-contracts.md
e78b093 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/messaging/core-contracts.md
5bee745 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/messaging/core-contracts.md
93cb0bb 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/messaging/core-contracts.md
77b97c8 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/messaging/core-contracts.md
6527e8e 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/messaging/core-contracts.md
c662c93 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/messaging/overview.md
d9b6bfc 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/messaging/overview.md
0e8b55f 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
feedback fixes
b9cf7e3
renaming token bridge page
fbd0bda
@ilariae ilariae requested review from eshaben and dawnkelly09 August 9, 2024 12:11
ilariae and others added 2 commits August 12, 2024 17:10
@ilariae @eshaben
Update learn/messaging/core-contracts.md
ea527ed 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
link fixes
638b304
eshaben
eshaben approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

dawnkelly09
dawnkelly09 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@dawnkelly09 dawnkelly09 merged commit b3f185a into main Aug 12, 2024
1 check passed
@dawnkelly09 dawnkelly09 deleted the ilariae/core-contracts branch August 12, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshaben eshaben eshaben approved these changes

@dawnkelly09 dawnkelly09 dawnkelly09 approved these changes

Assignees
No one assigned
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilariae @eshaben @dawnkelly09