lint: add linters with no violations #4307
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
added
the
quality
johnsaigle
force-pushed
the
free-linters
branch
5 times, most recently
from
5ddf3e7 to
74de37c
Compare
johnsaigle
force-pushed
the
free-linters
branch
2 times, most recently
from
6399c72 to
d40d1ee
Compare
|
Converting this to draft for now. We might as well update the major version of golangci-lint first as it changes to yml format. #4322 It's also possible that these linters will have violations in the new major version, so I'll need to revise the contents of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new linters to golangci-lint, specifically ones that the current code does not violate. The idea here is to get these new linters "for free" and prevent any future code from violating these rules.
Related:
This PR has different scope from these other open PRs, as they aim to resolve violations: