fixes

xarray-contrib · Dec 5, 2023 · 0e382f7 · 0e382f7
1 parent bb2b68f
commit 0e382f7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/cf_xarray/accessor.py b/cf_xarray/accessor.py
@@ -108,7 +108,7 @@ def apply_mapper(
     """
 
     if not isinstance(key, Hashable):
-        if default is None:
+        if default is None:  # type: ignore[unreachable]
             raise ValueError(
                 "`default` must be provided when `key` is not not a valid DataArray name (of hashable type)."
             )
@@ -858,7 +858,7 @@ def check_results(names, key):
         ds = ds.reset_coords()[varnames + coords]
         if isinstance(obj, DataArray):
             if scalar_key:
-                if len(ds.variables) == 1:
+                if len(ds.variables) == 1:  # type: ignore[unreachable]
                     # single dimension coordinates
                     assert coords
                     assert not varnames

diff --git a/cf_xarray/criteria.py b/cf_xarray/criteria.py
@@ -7,7 +7,7 @@
 try:
     import regex as re
 except ImportError:
-    import re  # type: ignore
+    import re  # type: ignore[no-redef]
 
 from collections.abc import Mapping, MutableMapping
 from typing import Any

diff --git a/cf_xarray/tests/test_accessor.py b/cf_xarray/tests/test_accessor.py
@@ -1489,7 +1489,7 @@ def test_new_standard_name_mappers() -> None:
     )
     assert_identical(forecast.cf.chunk({"realization": 1}), forecast.chunk({"M": 1}))
     assert_identical(forecast.cf.isel({"realization": 1}), forecast.isel({"M": 1}))
-    assert_identical(forecast.cf.isel(**{"realization": 1}), forecast.isel(**{"M": 1}))
+    assert_identical(forecast.cf.isel(realization=1), forecast.isel(M=1))
     assert_identical(
         forecast.cf.groupby("forecast_reference_time.month").mean(),
         forecast.groupby("S.month").mean(),