Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_bounds_dim_name regression. #473

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Fix get_bounds_dim_name regression. #473

merged 4 commits into from
Oct 24, 2023

Conversation

dcherian
Copy link
Contributor

Handle the case where lat and lat_bounds have same attributes.

Closes #442

dcherian and others added 3 commits October 24, 2023 09:31
@dcherian dcherian enabled auto-merge (squash) October 24, 2023 15:31
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #473 (42680ec) into main (c4d662e) will decrease coverage by 0.02%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   86.12%   86.11%   -0.02%     
==========================================
  Files          22       22              
  Lines        4209     4220      +11     
  Branches      207      210       +3     
==========================================
+ Hits         3625     3634       +9     
- Misses        527      528       +1     
- Partials       57       58       +1     
Flag Coverage Δ
mypy 37.97% <16.66%> (-0.06%) ⬇️
unittests 95.86% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cf_xarray/tests/test_accessor.py 94.08% <100.00%> (+0.02%) ⬆️
cf_xarray/accessor.py 85.90% <71.42%> (-0.09%) ⬇️

@dcherian dcherian merged commit 03583e4 into main Oct 24, 2023
8 of 10 checks passed
@dcherian dcherian deleted the fix-bounds-dim branch October 24, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bug with get_bounds_dim_name
1 participant