Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add min xarray pin on run and numpy py ver linters #536

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

ocefpaf
Copy link
Contributor

@ocefpaf ocefpaf commented Sep 11, 2024

@dcherian feel free to close this b/c it may not fit your ideas. I thought it was odd that a min pin is necessary to build cf_xarray but not to run. That can lead to slower solves and, if there is a xarray>=2022.03.0 feature necessary at run time, one can create a broken environment the way it is.

I also bumped the linters to use the min support Python version. However, I'm pretty sure ruff reads requires-python if you omit those, reducing the amount of things to remember to edit at every version bump.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.73%. Comparing base (a9cebee) to head (b33a47f).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
cf_xarray/coding.py 20.00% 4 Missing ⚠️
cf_xarray/accessor.py 66.66% 2 Missing ⚠️
cf_xarray/sgrid.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   85.78%   85.73%   -0.06%     
==========================================
  Files          13       13              
  Lines        2364     2621     +257     
  Branches      183      238      +55     
==========================================
+ Hits         2028     2247     +219     
- Misses        303      334      +31     
- Partials       33       40       +7     
Flag Coverage Δ
mypy 41.36% <23.52%> (+2.82%) ⬆️
unittests 93.49% <90.90%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcherian
Copy link
Contributor

Thanks Filipe, sorry for the trouble :/

@dcherian dcherian enabled auto-merge (squash) September 11, 2024 18:52
@dcherian dcherian merged commit 7072f70 into xarray-contrib:main Sep 11, 2024
10 checks passed
@ocefpaf ocefpaf deleted the min_pin_xarray_run branch September 11, 2024 18:58
@ocefpaf
Copy link
Contributor Author

ocefpaf commented Sep 11, 2024

Thanks Filipe, sorry for the trouble :/

You mean the trouble of having a great package that handles all the CF metadata for me? Please trouble me like that, all the time ;-p

@dcherian
Copy link
Contributor

I've had a rough week on conda-forge hehe

conda-forge/flox-feedstock#65

@ocefpaf
Copy link
Contributor Author

ocefpaf commented Sep 12, 2024

I've had a rough week on conda-forge hehe

conda-forge/flox-feedstock#65

I'll take care of that as soon as I arrive home. Traveling back from the USA today. It should be easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants