Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update META file to use plugin convention #33

Merged
merged 1 commit into from
May 20, 2020

Conversation

bobot
Copy link
Contributor

@bobot bobot commented May 18, 2020

The archive(native,plugin) convention was used before ocamlfind defined one using plugin

The `archive(native,plugin)` convention was used before ocamlfind defined one using `plugin`
@bobot
Copy link
Contributor Author

bobot commented May 18, 2020

ocamlfind lint also advice to add a description.

@bobot
Copy link
Contributor Author

bobot commented May 18, 2020

This one should not be needed if #31 is used.

Copy link
Owner

@xavierleroy xavierleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Now merging.

@@ -3,3 +3,5 @@ requires="unix"
archive(byte)="zip.cma"
archive(native)="zip.cmxa"
archive(native,plugin)="zip.cmxs"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume this line archive(native,plugin)="zip.cmxs" is still useful, or at least doesn't hurt.

@xavierleroy xavierleroy merged commit f5aba99 into xavierleroy:master May 20, 2020
@bobot bobot mentioned this pull request Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants